don't update updated_at date when read the notifications.

updated_at is displayed in the frontend and should only be updated when
another notification_actor gets added

Also improved the sql-queries: update directly and not select first and
update then.

app/services/post_service.rb

@@ -46,15 +46,13 @@ class PostService
   end
 
   def mark_comment_reshare_like_notifications_read(post_id)
-    notifications = Notification.where(recipient_id: user.id, target_type: "Post", target_id: post_id, unread: true)
+    Notification.where(recipient_id: user.id, target_type: "Post", target_id: post_id, unread: true)
-    notifications.each do |notification|
+      .update_all(unread: false)
-      notification.set_read_state(true)
-    end
   end
 
   def mark_mention_notifications_read(post_id)
-    mention = find(post_id).mentions.where(person_id: user.person_id).first
+    mention_id = Mention.where(post_id: post_id, person_id: user.person_id).pluck(:id)
-    Notification.where(recipient_id: user.id, target_type: "Mention", target_id: mention.id, unread: true)
+    Notification.where(recipient_id: user.id, target_type: "Mention", target_id: mention_id, unread: true)
-      .first.try(:set_read_state, true) if mention
+      .update_all(unread: false) if mention_id
   end
 end

spec/services/post_service_spec.rb

@@ -93,6 +93,28 @@ describe PostService do
       }.to change(Notification.where(unread: true), :count).by(-1)
     end
 
+    it "does not change the update_at date/time for post notifications" do
+      notification = Timecop.travel(1.minute.ago) do
+        FactoryGirl.create(:notification, recipient: alice, target: post, unread: true)
+      end
+
+      expect {
+        PostService.new(alice).mark_user_notifications(post.id)
+      }.not_to change { Notification.where(id: notification.id).pluck(:updated_at) }
+    end
+
+    it "does not change the update_at date/time for mention notifications" do
+      status_text = "this is a text mentioning @{Mention User ; #{alice.diaspora_handle}} ... have fun testing!"
+      mention_post = Timecop.travel(1.minute.ago) do
+        bob.post(:status_message, text: status_text, public: true)
+      end
+      mention = mention_post.mentions.where(person_id: alice.person.id).first
+
+      expect {
+        PostService.new(alice).mark_user_notifications(post.id)
+      }.not_to change { Notification.where(target_type: "Mention", target_id: mention.id).pluck(:updated_at) }
+    end
+
     it "does nothing without a user" do
       expect_any_instance_of(PostService).not_to receive(:mark_comment_reshare_like_notifications_read).with(post.id)
       expect_any_instance_of(PostService).not_to receive(:mark_mention_notifications_read).with(post.id)