diff --git a/Gemfile b/Gemfile
index 3a8199dd7..371bd9fa3 100644
--- a/Gemfile
+++ b/Gemfile
@@ -50,6 +50,7 @@ gem 'json', '1.4.6'
gem 'http_accept_language', :git => 'git://github.com/iain/http_accept_language.git', :ref => '0b78aa7849fc90cf9e12'
gem 'thin', '1.2.11', :require => false
+gem 'redcarpet', :git => 'git://github.com/tanoku/redcarpet'
#Websocket
gem 'em-websocket', :git => 'git://github.com/igrigorik/em-websocket', :ref => 'e278f5a1c4db60be7485'
diff --git a/Gemfile.lock b/Gemfile.lock
index 15d2b5f03..119db8033 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -56,6 +56,12 @@ GIT
addressable (>= 2.1.1)
eventmachine (>= 0.12.9)
+GIT
+ remote: git://github.com/tanoku/redcarpet
+ revision: 6b43f042305eb63620e3771a977f45e24ea7b576
+ specs:
+ redcarpet (2.0.0b3)
+
GIT
remote: git://github.com/zhitomirskiyi/ruby-jwt.git
revision: fa7f46b5ac3653e30cf60abc78de9ffb3319dc0c
@@ -500,6 +506,7 @@ DEPENDENCIES
rails (= 3.0.9)
rails-i18n
rcov
+ redcarpet!
resque (= 1.10.0)
resque-ensure-connected
rest-client (= 1.6.1)
diff --git a/app/helpers/markdownify_helper.rb b/app/helpers/markdownify_helper.rb
index edf3c7f74..ef38d352d 100644
--- a/app/helpers/markdownify_helper.rb
+++ b/app/helpers/markdownify_helper.rb
@@ -2,134 +2,27 @@
# licensed under the Affero General Public License version 3 or later. See
# the COPYRIGHT file.
+require 'lib/diaspora/markdownify'
+
module MarkdownifyHelper
- def markdownify(message, options={})
- message = h(message).to_str
+ def markdownify(message, render_options={})
+ markdown_options = {
+ :autolink => true,
+ }
- options[:newlines] = true if !options.has_key?(:newlines)
- options[:specialchars] = true if !options.has_key?(:specialchars)
+ render_options[:filter_html] = true
- message = process_links(message)
- message = process_autolinks(message)
- message = process_emphasis(message)
- message = process_youtube(message, options[:youtube_maps])
- message = process_vimeo(message, options[:vimeo_maps])
- message = process_specialchars(message) if options[:specialchars]
- message = process_newlines(message) if options[:newlines]
-
- message.html_safe
+ renderer = Diaspora::Markdownify::HTML.new(render_options)
+ markdown = Redcarpet::Markdown.new(renderer, markdown_options)
+ message = markdown.render(message)
+ return message.html_safe
end
def process_newlines(message)
- message.gsub!(/\n+/, '
')
- message
- end
-
- def process_links(message)
- message.gsub!(/\[\s*([^\[]+?)\s*\]\(\s*([^ ]+\s*) \"(([^&]|(&[^q])|(&q[^u])|(&qu[^o])|(&quo[^t])|("[^;]))+)\"\s*\)/) do |m|
- escape = "\\"
- link = $1
- url = $2
- title = $3
- url.gsub!("_", "\\_")
- url.gsub!("*", "\\*")
- protocol = (url =~ /^\w+:\/\//) ? '' :'http://'
- res = "#{link}"
- res
+ # in very clear cases, let newlines become
tags
+ # Grabbed from Github flavored Markdown
+ message.gsub(/^[\w\<][^\n]*\n+/) do |x|
+ x =~ /\n{2}/ ? x : (x.strip!; x << " \n")
end
-
- message.gsub!(/\[\s*([^\[]+?)\s*\]\(\s*([^ ]+)\s*\)/) do |m|
- escape = "\\"
- link = $1
- url = $2
- url.gsub!("_", "\\_")
- url.gsub!("*", "\\*")
- protocol = (url =~ /^\w+:\/\//) ? '' :'http://'
- res = "#{link}"
- res
- end
-
- message
- end
-
- def process_youtube(message, youtube_maps)
- processed_message = message.gsub(YoutubeTitles::YOUTUBE_ID_REGEX) do |matched_string|
- match_data = matched_string.match(YoutubeTitles::YOUTUBE_ID_REGEX)
- video_id = match_data[1]
- anchor = match_data[2]
- anchor ||= ''
- if youtube_maps && youtube_maps[video_id]
- title = h(CGI::unescape(youtube_maps[video_id]))
- else
- title = I18n.t 'application.helper.video_title.unknown'
- end
- ' Youtube: ' + title + ''
- end
- processed_message
- end
-
- def process_autolinks(message)
- message.gsub!(/( |^)(www\.[^\s]+\.[^\s])/, '\1http://\2')
- message.gsub!(/(#{captures[2]}}
- res.gsub!(/(\*|_)/) { |m| "\\#{$1}" }
- res
- end
- end
- message
- end
-
- def process_emphasis(message)
- message.gsub!("\\**", "-^doublestar^-")
- message.gsub!("\\__", "-^doublescore^-")
- message.gsub!("\\*", "-^star^-")
- message.gsub!("\\_", "-^score^-")
- message.gsub!(/(\*\*\*|___)(.+?)\1/m, '\2')
- message.gsub!(/(\*\*|__)(.+?)\1/m, '\2')
- message.gsub!(/(\*|_)(.+?)\1/m, '\2')
- message.gsub!("-^doublestar^-", "**")
- message.gsub!("-^doublescore^-", "__")
- message.gsub!("-^star^-", "*")
- message.gsub!("-^score^-", "_")
- message
- end
-
- def process_vimeo(message, vimeo_maps)
- regex = /https?:\/\/(?:w{3}\.)?vimeo.com\/(\d{6,})\/?/
- processed_message = message.gsub(regex) do |matched_string|
- match_data = message.match(regex)
- video_id = match_data[1]
- if vimeo_maps && vimeo_maps[video_id]
- title = h(CGI::unescape(vimeo_maps[video_id]))
- else
- title = I18n.t 'application.helper.video_title.unknown'
- end
- ' Vimeo: ' + title + ''
- end
- processed_message
- end
-
- def process_specialchars(message)
- map = [
- ["<3", "♥"],
- ["<->", "↔"],
- ["->", "→"],
- ["<-", "←"],
- ["...", "…"],
- ["(tm)", "™"],
- ["(r)", "®"],
- ["(c)", "©"]
- ]
-
- map.each do |mapping|
- message.gsub!(mapping[0], mapping[1])
- end
- message
end
end
diff --git a/features/follows_tags.feature b/features/follows_tags.feature
index d6b0afda1..b74fb8fb1 100644
--- a/features/follows_tags.feature
+++ b/features/follows_tags.feature
@@ -25,7 +25,7 @@ Feature: posting
Scenario: see a tag that I am following
When I go to the home page
And I follow "#boss"
- Then I should see "I am da #boss"
+ Then I should see "I am da #boss" within "body"
Scenario: can stop following a particular tag
When I hover over the ".button.tag_following"
diff --git a/lib/diaspora/markdownify.rb b/lib/diaspora/markdownify.rb
new file mode 100644
index 000000000..734e34f01
--- /dev/null
+++ b/lib/diaspora/markdownify.rb
@@ -0,0 +1,169 @@
+require 'uri'
+
+module Diaspora
+ module Markdownify
+ class HTML < Redcarpet::Render::HTML
+ attr_accessor :newlines, :specialchars, :youtube_maps, :vimeo_maps
+
+ def initialize(options={})
+ super
+
+ @expand_tags = options.fetch(:expand_tabs, true)
+ @newlines = options.fetch(:newlines, true)
+ @specialchars = options.fetch(:specialchars, true)
+ @youtube_maps = options.fetch(:youtube_maps, {})
+ @vimeo_maps = options.fetch(:vimeo_maps, {})
+ end
+
+ def autolink(link, type)
+ autolink_youtube(link) || autolink_vimeo(link) || autolink_simple(link)
+ end
+
+ def autolink_simple(link)
+
+ # If there isn't *some* protocol, assume http
+ if link !~ %r{^\w+://}
+ link = "http://#{link}"
+ end
+
+ content = link.gsub(%r{^\w+://}, '')
+
+ %Q{#{content}}
+ end
+
+ def autolink_vimeo(link)
+ regex = %r{https?://(?:w{3}\.)?vimeo.com/(\d{6,})/?}
+ if link =~ regex
+ video_id = $1
+ if @vimeo_maps[video_id]
+ title = h(CGI::unescape(@vimeo_maps[video_id]))
+ else
+ title = I18n.t 'application.helper.video_title.unknown'
+ end
+ return ' Vimeo: ' + title + ''
+ end
+ end
+
+ def autolink_youtube(link)
+ if link =~ YoutubeTitles::YOUTUBE_ID_REGEX
+ video_id = $1
+ anchor = $2 || ''
+
+ if @youtube_maps[video_id]
+ title = h(CGI::unescape(@youtube_maps[video_id]))
+ else
+ title = I18n.t 'application.helper.video_title.unknown'
+ end
+ return ' Youtube: ' + title + ''
+ end
+ end
+
+ def double_emphasis(text)
+ "#{text}"
+ end
+
+ def linebreak()
+ "
"
+ end
+
+ def link(link, title, content)
+ return autolink(link, 'url') if link == content
+
+ if link =~ Regexp.new(Regexp.escape(content))
+ return autolink(link, 'url')
+ end
+
+ if link !~ %r{^\w+://}
+ link = "http://#{link}"
+ end
+
+ tag = if title and content
+ %Q{#{content}}
+ elsif content
+ %Q{#{content}}
+ else
+ autolink(link, 'url')
+ end
+ return tag
+ end
+
+ def paragraph(text)
+ if @expand_tags
+ text = Diaspora::Taggable.format_tags(text, :no_escape => true)
+ end
+
+ return "
#{text}
" + end + + + def preprocess(full_document) + if @specialchars + full_document = specialchars(full_document) + end + + our_unsafe_chars = '()' + full_document = full_document.gsub(%r{ + \[ \s*? ( [^ \] ]+ ) \s*? \] + (?: + \( \s*? (\S+) \s*? (?: "([^"]+)" )? \) \s*? + ) + }xm) do |m| + content = $1 + link = URI.escape($2, our_unsafe_chars) + title = $3 + + title_chunk = if title + %W{" #{title}"} + else + '' + end + %Q{[#{content}](#{link}#{title_chunk})} + end + + if @newlines + # in very clear cases, let newlines becomealert('XSS is evil')
" end it "should recognize basic http links (1/3)" do proto="http" url="bugs.joindiaspora.com/issues/332" - markdownify(proto+"://"+url).should == ""+url+"" + full_url = "#{proto}://#{url}" + markdownify(full_url).should == %Q{} end it "should recognize basic http links (2/3)" do proto="http" url="webmail.example.com?~()!*/" - markdownify(proto+"://"+url).should == ""+url+"" + full_url = "#{proto}://#{url}" + markdownify(full_url).should == %Q{} end it "should recognize basic http links (3/3)" do proto="http" url="127.0.0.1:3000/users/sign_in" - markdownify(proto+"://"+url).should == ""+url+"" + full_url = "#{proto}://#{url}" + markdownify(full_url).should == %Q{} end it "should recognize secure https links" do proto="https" url="127.0.0.1:3000/users/sign_in" - markdownify(proto+"://"+url).should == ""+url+"" + full_url = "#{proto}://#{url}" + markdownify(full_url).should == %Q{} end it "doesn't double parse video links" do @@ -40,8 +44,8 @@ describe MarkdownifyHelper do http://www.youtube.com/watch?v=0x__dDWdf23&a=GxdCwVVULXdvEBKmx_f5ywvZ0zZHHHDU&list=ML&playnext=1 http://youtu.be/x_CzD0GBD-4" res = markdownify(message) - res.should =~ /href.+href.+href/ - res.should_not =~ /href.+href.+href.+href/ + res.should =~ /href.+href.+href/m + res.should_not =~ /href.+href.+href.+href/m end describe "video links" do @@ -69,6 +73,12 @@ describe MarkdownifyHelper do res.should =~ /Youtube:/ res.should =~ /data-host="youtube.com"/ res.should =~ /data-video-id="#{video_id}"/ + + url = "www.youtube.com/watch?foo=bar&v=BARFOO-----&whatever=related" + res = markdownify(url) + res.should =~ /Youtube:/ + res.should =~ /data-host="youtube.com"/ + res.should =~ /data-video-id="BARFOO-----"/ end it "recognizes youtu.be links" do @@ -141,113 +151,135 @@ describe MarkdownifyHelper do proto="ftp" url="ftp.uni-kl.de/CCC/26C3/mp4/26c3-3540-en-a_hackers_utopia.mp4" # I did not watch that one, but the title sounds nice :P - markdownify(proto+"://"+url).should == ""+url+"" + markdownify(proto+"://"+url).should == "" end it "should recognize www links" do url="www.joindiaspora.com" - markdownify(url).should == ""+url+"" + markdownify(url).should == %Q{} end end describe "specialchars" do it "replaces <3 with ♥" do message = "i <3 you" - markdownify(message).should == "i ♥ you" + markdownify(message).should == "i ♥ you
" end it "replaces various things with (their) HTML entities" do message = "... <-> -> <- (tm) (r) (c)" - markdownify(message).should == "… ↔ → ← ™ ® ©" + markdownify(message).should == "… ↔ → ← ™ ® ©
" end it "skips doing it if you say so" do message = "... -> <-" - markdownify(message, :specialchars => false).should == "... -> <-" + markdownify(message, :specialchars => false).should == "... -> <-
" end end describe "weak emphasis" do it "should be recognized (1/2)" do message = "*some text* some text *some text* some text" - markdownify(message).should == "some text some text some text some text" + markdownify(message).should == "some text some text some text some text
" end it "should be recognized (2/2)" do message = "_some text_ some text _some text_ some text" - markdownify(message).should == "some text some text some text some text" + markdownify(message).should == "some text some text some text some text
" end end describe "strong emphasis" do it "should be recognized (1/2)" do message = "**some text** some text **some text** some text" - markdownify(message).should == "some text some text some text some text" + markdownify(message).should == "some text some text some text some text
" end it "should be recognized (2/2)" do message = "__some text__ some text __some text__ some text" - markdownify(message).should == "some text some text some text some text" + markdownify(message).should == "some text some text some text some text
" end end describe "nested weak and strong emphasis" do it "should be rendered correctly" do message = "__this is _some_ text__" - markdownify(message).should == "this is some text" + markdownify(message).should == "this is some text
" message = "*this is **some** text*" - markdownify(message).should == "this is some text" + markdownify(message).should == "this is some text
" message = "___some text___" - markdownify(message).should == "some text" + markdownify(message).should == "some text
" end end describe "links" do it "should be recognized without title attribute" do message = "[link text](http://someurl.com) [link text](http://someurl.com)" - markdownify(message).should == 'link text link text' + markdownify(message).should == '' end it "should be recognized with title attribute" do message = '[link text](http://someurl.com "some title") [link text](http://someurl.com "some title")' - markdownify(message).should == 'link text link text' + markdownify(message).should == '' end it "should have a robust link parsing" do + message = "[wikipedia](http://en.wikipedia.org/wiki/Text_(literary_theory))" + link = markdownify(message) + link.should =~ %r{href="http://en.wikipedia.org/wiki/Text_%28literary_theory%29"} + + message = "[ links]( google.com)" + markdownify(message).should == %Q{} + + message = "[_http_](http://google.com/search?q=with_multiple__underscores*and**asterisks )" + markdownify(message).should == %Q{} + message = %{[___FTP___]( ftp://ftp.uni-kl.de/CCC/26C3/mp4/26c3-3540-en-a_hackers_utopia.mp4 \"File Transfer Protocol\")} + markdownify(message).should == %{} + + message = %{[**any protocol**](foo://bar.example.org/yes_it*makes*no_sense)} + markdownify(message).should == %{} + message = "This [ *text* ]( http://en.wikipedia.org/wiki/Text_(literary_theory) ) with many [ links]( google.com) tests [_http_](http://google.com/search?q=with_multiple__underscores*and**asterisks ), [___FTP___]( ftp://ftp.uni-kl.de/CCC/26C3/mp4/26c3-3540-en-a_hackers_utopia.mp4 \"File Transfer Protocol\"), [**any protocol**](foo://bar.example.org/yes_it*makes*no_sense)" - markdownify(message).should == 'This text with many links tests http, FTP, any protocol' + markdownify(message).should == 'This text with many links tests http, FTP, any protocol
' + end + + it "should leave #tag links intact" do + message = %{#tagged} + markdownify(message).should == "#{message}
" + message = %{alice - 1 - #tagged} + markdownify(message).should == "#{message}
" end end describe "nested emphasis and links tags" do it "should be rendered correctly" do message = '[**some *link* text**](someurl.com "some title")' - markdownify(message).should == 'some link text' + markdownify(message).should == '' end end it "should allow escaping" do - message = '*some text* \\*some text* \\**some text* _some text_ \\_some text_ \\__some text_' - markdownify(message).should == "some text *some text **some text some text _some text __some text" + message = '*some text* \*some text* \**some text* _some text_ \_some text_ \__some text_' + markdownify(message).should == "some text *some text* *some text some text _some text_ _some text
" end describe "newlines" do it 'skips inserting newlines if you pass the newlines option' do message = "These\nare\n\some\nnew\lines" res = markdownify(message, :newlines => false) - res.should == message + res.should == "#{message}
" end it 'generates breaklines' do message = "These\nare\nsome\nnew\nlines" res = markdownify(message) - res.should == "TheseThese
are
some
new
lines
Some text, then a line break and a link
joindiaspora.com
some more text