Use double quotes when embeding translations in JS

Translations commonly include single quotes, which closes
the JavaScript string unexpectedly. Closes #5055

Changelog.md

@@ -9,6 +9,7 @@
 * Fix padding in user menu [#5047](https://github.com/diaspora/diaspora/pull/5047)
 * Fix self-XSS when renaming an aspect [#5048](https://github.com/diaspora/diaspora/pull/5048)
 * Fix live updating when renaming an aspect [#5049](https://github.com/diaspora/diaspora/pull/5049)
+* Use double quotes when embedding translations into Javascript [#5055](https://github.com/diaspora/diaspora/issues/5055)
 
 ## Features
 * Port admin pages to bootstrap, polish user search results, allow accounts to be closed from the backend [#5046](https://github.com/diaspora/diaspora/pull/5046)

app/views/conversations/new.haml

@@ -19,7 +19,7 @@
       minChars: 1,
       keyDelay: 0,
       startText: '',
-      emptyText: '#{t('no_results')}',
+      emptyText: "#{t('no_results')}",
       preFill: [{name : "#{h params[:name]}",
                  value : "#{@contact_ids}"}]
       });