diff --git a/Changelog.md b/Changelog.md index 84ca85b6e..a1ff5687d 100644 --- a/Changelog.md +++ b/Changelog.md @@ -24,6 +24,7 @@ * Fixed Atom Feed Error if reshared Post is deleted [#4638] (https://github.com/diaspora/diaspora/issues/4638) * Show hovercards in the notification drop-down for users on the same pod [#4843](https://github.com/diaspora/diaspora/pull/4843) * The photo stream no longer repeats after the last photo [#4726](https://github.com/diaspora/diaspora/issues/4726) +* Stop parsing hashtags inside markdown links [#3692](https://github.com/diaspora/diaspora/issues/3692) ## Features * You can report a single post by clicking the correct icon in the controler section [#4517](https://github.com/diaspora/diaspora/pull/4517) diff --git a/app/assets/javascripts/app/helpers/text_formatter.js b/app/assets/javascripts/app/helpers/text_formatter.js index 3e122d87a..0ae8e9d5d 100644 --- a/app/assets/javascripts/app/helpers/text_formatter.js +++ b/app/assets/javascripts/app/helpers/text_formatter.js @@ -108,11 +108,16 @@ $(function() { }; textFormatter.hashtagify = function hashtagify(text){ - var utf8WordCharcters =/(\s|^|>)#([\u0080-\uFFFF|\w|-]+|<3)/g - return text.replace(utf8WordCharcters, function(hashtag, preceeder, tagText) { - return preceeder + "#" + tagText + "" - }) + var utf8WordCharcters =/(\s|^|>)#([\u0080-\uFFFF|\w|-]+|<3)/g; + var linkRegex = /]*>(.*?)<\/a>/g; + + if(text.match(linkRegex)) + return text; + else + return text.replace(utf8WordCharcters, function(hashtag, preceeder, tagText) { + return preceeder + "#" + tagText + "" + }); }; textFormatter.mentionify = function mentionify(text, mentions) { diff --git a/spec/javascripts/app/helpers/text_formatter_spec.js b/spec/javascripts/app/helpers/text_formatter_spec.js index 29aec511e..2c1461b69 100644 --- a/spec/javascripts/app/helpers/text_formatter_spec.js +++ b/spec/javascripts/app/helpers/text_formatter_spec.js @@ -238,6 +238,13 @@ describe("app.helpers.textFormatter", function(){ expect(formattedText).toContain("/tags/parties") }) + + it("doesn't create tag if the text is a link", function(){ + var link = $('', { href: 'http://me.co' }).html('#me')[0].outerHTML; + var result = this.formatter.hashtagify(link); + + expect(result).toEqual(link); + }) }) })