nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix: Failing 'Signs Up'-Feature Tests

Browse source 
Up to now, scripts were loaded prior to the stylesheet in <head>. When
scripts are loaded before stylesheets, it is possible that scripts
execute on the DOM elements before styles are fully loaded. This can
yield unexpected results.

In the case of the features/desktop/signs_up.feature tests, it would
happen every so often that the scripts ran before styles were loaded.
For example, the app.views.Publisher class (responsible for actions
related to creating a new post) relies on the poll element being either
hidden (or poll options being defined). As per stylesheet, the poll is
hidden by default. But when the scripts run before the stylesheet has
loaded, the poll appears visible to the script and post submission is
disabled.

This is fixed by loading stylesheets prior to scripts. See SO for more
info: https://stackoverflow.com/a/1324720/6451879
This commit is contained in:
Finn Woelm 2017-07-18 13:53:14 +07:00
parent 21263edbdf
commit 070ef782e6
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/views/layouts/application.html.haml
View file

@ -17,8 +17,8 @@
= javascript_include_tag :main, :templates = javascript_include_tag :main, :templates
= load_javascript_locales = load_javascript_locales
= render "head"
= include_color_theme = include_color_theme
= render "head"
= translation_missing_warnings = translation_missing_warnings
%body{class: "page-#{controller_name} action-#{action_name}"} %body{class: "page-#{controller_name} action-#{action_name}"}