Merge pull request #5008 from jaywink/bookmarklet-notes-linefeeds

Fix broken bookmarklet if params have encoded linefeeds.

app/assets/javascripts/app/router.js

@@ -21,9 +21,14 @@ app.Router = Backbone.Router.extend({
     "people/:id/photos": "photos",
 
     "people/:id": "stream",
-    "u/:name": "stream",
+    "u/:name": "stream"
-
+  },
-    "bookmarklet": "bookmarklet"
+  
+  initialize: function() {
+    // To support encoded linefeeds (%0A) we need to specify
+    // our own internal router.route call with the correct regexp.
+    // see: https://github.com/diaspora/diaspora/issues/4994#issuecomment-46431124
+    this.route(/^bookmarklet(?:\?(.*))?/, "bookmarklet");
   },
 
   help: function() {

spec/javascripts/app/router_spec.js

@@ -69,4 +69,14 @@ describe('app.Router', function () {
       expect(hideFollowedTags).toHaveBeenCalled();
     });
   });
+
+  describe("bookmarklet", function() {
+    it('routes to bookmarklet even if params have linefeeds', function()  {
+      router = new app.Router();
+      var route = jasmine.createSpy('bookmarklet route');
+      router.on('route:bookmarklet', route);
+      router.navigate("/bookmarklet?\n\nfeefwefwewef\n", {trigger: true});
+      expect(route).toHaveBeenCalled();
+    });
+  });
 });