From 099e0a6e24c3c954d6b09984d40d92dbe810a89d Mon Sep 17 00:00:00 2001 From: Dan Hansen Date: Sat, 29 Jan 2011 16:40:10 -0600 Subject: [PATCH] i18n is the first widget to be loaded, add video locales, embedder uses i18n, only render mustache template with i18n if the views are passed --- config/assets.yml | 2 +- config/locales/diaspora/en.yml | 6 +++++- public/javascripts/widgets/embedder.js | 8 +++++--- public/javascripts/widgets/i18n.js | 6 +++++- 4 files changed, 16 insertions(+), 6 deletions(-) diff --git a/config/assets.yml b/config/assets.yml index 5f122ba6f..184cf2e8f 100644 --- a/config/assets.yml +++ b/config/assets.yml @@ -16,9 +16,9 @@ javascripts: - public/javascripts/vendor/fileuploader.js - public/javascripts/vendor/Mustache.js - public/javascripts/diaspora.js + - public/javascripts/widgets/i18n.js - public/javascripts/widgets/alert.js - public/javascripts/widgets/embedder.js - - public/javascripts/widgets/i18n.js - public/javascripts/widgets/timeago.js - public/javascripts/view.js - public/javascripts/stream.js diff --git a/config/locales/diaspora/en.yml b/config/locales/diaspora/en.yml index 6c378144e..967ee416d 100644 --- a/config/locales/diaspora/en.yml +++ b/config/locales/diaspora/en.yml @@ -499,4 +499,8 @@ en: next: "Next" previous: "Previous" javascripts: - confirm_dialog: "Are you sure?" + confirm_dialog: "Are you sure?" + videos: + watch: "Watch this video on {{provider}}" + unknown: "Unknown video type" + diff --git a/public/javascripts/widgets/embedder.js b/public/javascripts/widgets/embedder.js index 44dc1d1b7..81ab4d93d 100644 --- a/public/javascripts/widgets/embedder.js +++ b/public/javascripts/widgets/embedder.js @@ -56,15 +56,17 @@ }; Embedder.prototype.registerServices = function() { + var watchVideoOn = Diaspora.widgets.i18n.t("videos.watch"); + console.log(watchVideoOn); this.register("youtube.com", - 'Watch this video on Youtube
' + + '' + $.mustache(watchVideoOn, { provider: "YouTube" }) + 'Youtube
' + ''); this.register("vimeo.com", - 'Watch this video on Vimeo
' + + '' + $.mustache(watchVideoOn, { provider: "Vimeo" }) + '
' + ''); - this.register("undefined", '

Unknown video type - {{host}}

'); + this.register("undefined", '

' + Diaspora.widgets.i18n.t("videos.unknown") + ' - {{host}}

'); }; Embedder.prototype.onVideoLinkClicked = function(evt) { diff --git a/public/javascripts/widgets/i18n.js b/public/javascripts/widgets/i18n.js index bb07a1af3..ade4fccba 100644 --- a/public/javascripts/widgets/i18n.js +++ b/public/javascripts/widgets/i18n.js @@ -27,6 +27,10 @@ Diaspora.widgets.add("i18n", function() { } } - return $.mustache(ret, views || {}); + if(typeof views === "object") { + return $.mustache(ret, views || {}); + } + + return ret; }; }); \ No newline at end of file