nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

OpenID Connect: ensure consistent issuer URL

Browse source 
root_url does not know the right protocol in all contexts,
some clients are strict when validating this.
This commit is contained in:
Jonne Haß 2020-10-24 22:30:43 +02:00
parent d27cd175df
commit 0aba20f85c
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/api/openid_connect/discovery_controller.rb
View file

@ -28,7 +28,7 @@ module Api
class DiscoveryController < ApplicationController class DiscoveryController < ApplicationController
def configuration def configuration
render json: OpenIDConnect::Discovery::Provider::Config::Response.new( render json: OpenIDConnect::Discovery::Provider::Config::Response.new(
issuer: root_url, issuer: AppConfig.environment.url,
registration_endpoint: api_openid_connect_clients_url, registration_endpoint: api_openid_connect_clients_url,
authorization_endpoint: new_api_openid_connect_authorization_url, authorization_endpoint: new_api_openid_connect_authorization_url,
token_endpoint: api_openid_connect_access_tokens_url, token_endpoint: api_openid_connect_access_tokens_url,

2
lib/api/openid_connect/id_token.rb
View file

@ -53,7 +53,7 @@ module Api
def claims def claims
sub = build_sub sub = build_sub
@claims ||= { @claims ||= {
iss: Rails.application.routes.url_helpers.root_url, iss: AppConfig.environment.url,
sub: sub, sub: sub,
aud: @authorization.o_auth_application.client_id, aud: @authorization.o_auth_application.client_id,
exp: @expires_at.to_i, exp: @expires_at.to_i,

2
spec/controllers/api/openid_connect/discovery_controller_spec.rb
View file

@ -8,7 +8,7 @@ describe Api::OpenidConnect::DiscoveryController, type: :controller do
it "should have the issuer as the root url" do it "should have the issuer as the root url" do
json_body = JSON.parse(response.body) json_body = JSON.parse(response.body)
expect(json_body["issuer"]).to eq(root_url) expect(json_body["issuer"]).to eq(AppConfig.environment.url)
end end
it "should have the appropriate user info endpoint" do it "should have the appropriate user info endpoint" do