fix regression in conversations causing an infinite recursion (fix #4715)

(cherry picked from commit 5c059b2925)

Conflicts:
	Changelog.md

Changelog.md

@@ -1,3 +1,8 @@
+# 0.3.0.1
+
+## Bug fixes
+* Fix regression caused by using after_commit with nested '#save' which lead to an infinite recursion [#4715](https://github.com/diaspora/diaspora/issues/4715)
+
 # 0.3.0.0
 
 ## Pod statistics

app/models/message.rb

@@ -11,13 +11,14 @@ class Message < ActiveRecord::Base
 
   belongs_to :author, :class_name => 'Person'
   belongs_to :conversation, :touch => true
-  
+
   delegate :name, to: :author, prefix: true
 
   validates :text, :presence => true
   validate :participant_of_parent_conversation
 
-  after_commit :on => :create do
+  after_create do  # don't use 'after_commit' here since there is a call to 'save!'
+                   # inside, which would cause an infinite recursion 
     #sign comment as commenter
     self.author_signature = self.sign_with_key(self.author.owner.encryption_key) if self.author.owner