Begin rescue on publics controller to make the post for nonexistent user error more readable

This commit is contained in:
Raphael 2010-08-18 11:46:28 -07:00
parent d640c0672f
commit 10aef7a0a3
3 changed files with 17 additions and 4 deletions

View file

@ -22,7 +22,11 @@ class PublicsController < ApplicationController
end
def receive
@user = Person.first(:id => params[:id]).owner
begin
@user = Person.first(:id => params[:id]).owner
rescue NoMethodError => e
Rails.logger.error("Received post #{params[:xml]} for nonexistent person #{params[:id}")
end
Rails.logger.debug "PublicsController has received: #{params[:xml]}"
@user.receive params[:xml] if params[:xml]
render :nothing => true

View file

@ -88,8 +88,5 @@ describe Album do
it 'should have an id' do
@xml.include?(@album.id.to_s).should be true
end
end
end

View file

@ -25,6 +25,18 @@ describe User do
Post.all(:person_id => person.id).first.message.should == 'store this!'
StatusMessage.all.size.should == 1
end
it 'should not create new groups on message receive' do
num_groups = @user.groups.size
(0..5).each{ |n|
status_message = @user2.post :status_message, :message => "store this #{n}!"
xml = status_message.to_diaspora_xml
@user.receive( xml )
}
@user.groups.size.should == num_groups
end
describe 'post refs' do
before do