diff --git a/Changelog.md b/Changelog.md index 4e136f1d4..2f569b5da 100644 --- a/Changelog.md +++ b/Changelog.md @@ -18,6 +18,7 @@ ## Refactor * Remove unused setPreload function [#7354](https://github.com/diaspora/diaspora/pull/7354) +* Remove jQuery deprecations [#7356](https://github.com/diaspora/diaspora/pull/7356) ## Bug fixes diff --git a/app/assets/javascripts/api/authorization_page.js b/app/assets/javascripts/api/authorization_page.js index d61b941ec..84b0f31b8 100644 --- a/app/assets/javascripts/api/authorization_page.js +++ b/app/assets/javascripts/api/authorization_page.js @@ -1,5 +1,5 @@ $(document).ready(function() { - $("#js-app-logo").error(function () { + $("#js-app-logo").on("error", function() { $(this).attr("src", ImagePaths.get("user/default.png")); }); }); diff --git a/app/assets/javascripts/app/views.js b/app/assets/javascripts/app/views.js index ebd8901a9..d0bede4ea 100644 --- a/app/assets/javascripts/app/views.js +++ b/app/assets/javascripts/app/views.js @@ -56,7 +56,7 @@ app.views.Base = Backbone.View.extend({ .attr("data-template", _.last(this.templateName.split("/"))); // add avatar fallback if it can't be loaded - this.$el.find(this.avatars.selector).error(this.avatars.fallback); + this.$el.find(this.avatars.selector).on("error", this.avatars.fallback); // add placeholder support for old browsers this.$("input, textarea").placeholder(); diff --git a/app/assets/javascripts/app/views/contact_stream_view.js b/app/assets/javascripts/app/views/contact_stream_view.js index cbc254c37..0fe60155e 100644 --- a/app/assets/javascripts/app/views/contact_stream_view.js +++ b/app/assets/javascripts/app/views/contact_stream_view.js @@ -18,7 +18,7 @@ app.views.ContactStream = Backbone.View.extend({ $("#paginate .loader").removeClass("hidden"); $.ajax(this._fetchUrl(), { context: this - }).success(function(response) { + }).done(function(response) { if (response.length === 0) { this.onEmptyResponse(); } else { diff --git a/app/assets/javascripts/app/views/notification_dropdown_view.js b/app/assets/javascripts/app/views/notification_dropdown_view.js index c3f8f1911..02c3a7137 100644 --- a/app/assets/javascripts/app/views/notification_dropdown_view.js +++ b/app/assets/javascripts/app/views/notification_dropdown_view.js @@ -96,7 +96,7 @@ app.views.NotificationDropdown = app.views.Base.extend({ afterNotificationChanges: function(node) { node.find(".unread-toggle .entypo-eye").tooltip("destroy").tooltip(); - node.find(this.avatars.selector).error(this.avatars.fallback); + node.find(this.avatars.selector).on("error", this.avatars.fallback); }, finishLoading: function() { diff --git a/app/assets/javascripts/app/views/publisher/uploader_view.js b/app/assets/javascripts/app/views/publisher/uploader_view.js index 775cf69bb..841952112 100644 --- a/app/assets/javascripts/app/views/publisher/uploader_view.js +++ b/app/assets/javascripts/app/views/publisher/uploader_view.js @@ -149,7 +149,7 @@ app.views.PublisherUploader = Backbone.View.extend({ dataType: "json", type: "DELETE", success: function() { - $.when(photo.fadeOut(400)).then(function(){ + photo.fadeOut(400, function() { photo.remove(); if( self.publisher.$(".publisher_photo").length === 0 ) { diff --git a/app/assets/javascripts/app/views/publisher_view.js b/app/assets/javascripts/app/views/publisher_view.js index 97bda7e12..160a77a95 100644 --- a/app/assets/javascripts/app/views/publisher_view.js +++ b/app/assets/javascripts/app/views/publisher_view.js @@ -43,7 +43,7 @@ app.views.Publisher = Backbone.View.extend({ // if there is data in the publisher we ask for a confirmation // before the user is able to leave the page $(window).on("beforeunload", _.bind(this._beforeUnload, this)); - $(window).unload(this.clear.bind(this)); + $(window).on("unload", this.clear.bind(this)); // hide close and preview buttons and manage services link // in case publisher is standalone diff --git a/app/assets/javascripts/app/views/tags_view.js b/app/assets/javascripts/app/views/tags_view.js index 9b70df1e6..3dda23c05 100644 --- a/app/assets/javascripts/app/views/tags_view.js +++ b/app/assets/javascripts/app/views/tags_view.js @@ -6,7 +6,7 @@ app.views.Tags = Backbone.View.extend({ app.publisher.setText("#"+ opts.hashtagName + " "); } // add avatar fallback if it can't be loaded - $(app.views.Base.prototype.avatars.selector).error(app.views.Base.prototype.avatars.fallback); + $(app.views.Base.prototype.avatars.selector).on("error", app.views.Base.prototype.avatars.fallback); } }); // @license-end diff --git a/spec/javascripts/app/app_spec.js b/spec/javascripts/app/app_spec.js index a1c987596..1ade3b556 100644 --- a/spec/javascripts/app/app_spec.js +++ b/spec/javascripts/app/app_spec.js @@ -4,6 +4,7 @@ describe("app", function() { spyOn(app.Router.prototype, "initialize"); spyOn(app, "setupDummyPreloads"); spyOn(app, "setupUser"); + spyOn(app, "setupAspects"); spyOn(app, "setupHeader"); spyOn(app, "setupBackboneLinks"); spyOn(app, "setupGlobalViews"); @@ -16,6 +17,7 @@ describe("app", function() { expect(app.Router.prototype.initialize).toHaveBeenCalled(); expect(app.setupDummyPreloads).toHaveBeenCalled(); expect(app.setupUser).toHaveBeenCalled(); + expect(app.setupAspects).toHaveBeenCalled(); expect(app.setupHeader).toHaveBeenCalled(); expect(app.setupBackboneLinks).toHaveBeenCalled(); expect(app.setupGlobalViews).toHaveBeenCalled(); @@ -39,18 +41,23 @@ describe("app", function() { }); describe("setupForms", function() { + beforeEach(function() { + spec.content().append("