Take httponly off of session cookies so that the websocket works in firefox 3.x. XSS attacks would now be easier to exploit if found. A possible replacement for opening this security hole is to set a new cookie value for Firefox users that stores a randomly generated key which would give a websocket with that key access.
This commit is contained in:
parent
ea0f0fbdc5
commit
229e202a72
2 changed files with 2 additions and 2 deletions
|
|
@ -4,7 +4,7 @@
|
|||
|
||||
# Be sure to restart your server when you modify this file.
|
||||
|
||||
Rails.application.config.session_store :cookie_store, :key => '_diaspora_session'
|
||||
Rails.application.config.session_store :cookie_store, :key => '_diaspora_session', :httponly => false
|
||||
|
||||
# Use the database for sessions instead of the cookie-based default,
|
||||
# which shouldn't be used to store highly confidential information
|
||||
|
|
|
|||
|
|
@ -25,7 +25,7 @@ def write_pidfile
|
|||
end
|
||||
|
||||
def debug_pp thing
|
||||
pp thing if APP_CONFIG[:socket_debug] || ENV[:SOCKET_DEBUG]
|
||||
pp thing if APP_CONFIG[:socket_debug] || ENV['SOCKET_DEBUG']
|
||||
end
|
||||
|
||||
CHANNEL = Magent::GenericChannel.new('websocket')
|
||||
|
|
|
|||
Loading…
Reference in a new issue