nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

DG DC; $("window") doesn't actually work in the binding scenario

Browse source
This commit is contained in:
danielgrippi 2012-01-19 17:16:58 -08:00
parent 750e26e8fb
commit 356494b78b
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
public/javascripts/app/views/stream_view.js
View file

@ -31,7 +31,7 @@ app.views.Stream = Backbone.View.extend({
}, },
unbindInfScroll : function() { unbindInfScroll : function() {
$("window").unbind("scroll"); $(window).unbind("scroll");
}, },
render : function(evt) { render : function(evt) {
@ -63,11 +63,11 @@ app.views.Stream = Backbone.View.extend({
setupInfiniteScroll : function() { setupInfiniteScroll : function() {
var throttledScroll = _.throttle($.proxy(this.infScroll, this), 200); var throttledScroll = _.throttle($.proxy(this.infScroll, this), 200);
$("window").scroll(throttledScroll); $(window).scroll(throttledScroll);
}, },
infScroll : function() { infScroll : function() {
var $window = $("window"); var $window = $(window);
var distFromTop = $window.height() + $window.scrollTop(); var distFromTop = $window.height() + $window.scrollTop();
var distFromBottom = $(document).height() - distFromTop; var distFromBottom = $(document).height() - distFromTop;
var bufferPx = 500; var bufferPx = 500;

1
spec/javascripts/app/views/stream_view_spec.js
View file

@ -65,7 +65,6 @@ describe("app.views.Stream", function(){
it("unbinds scroll", function() { it("unbinds scroll", function() {
spyOn($.fn, "unbind") spyOn($.fn, "unbind")
this.view.unbindInfScroll() this.view.unbindInfScroll()
expect($.fn.unbind.mostRecentCall.object.selector).toBe("window")
expect($.fn.unbind).toHaveBeenCalledWith("scroll") expect($.fn.unbind).toHaveBeenCalledWith("scroll")
}) })
}) })