From 37b34237b9909f5346d9d1ef7cd0a5d2df4c78fc Mon Sep 17 00:00:00 2001 From: Steffen van Bergerem Date: Sat, 12 Nov 2016 23:30:03 +0100 Subject: [PATCH] Force jasmine fails on syntax errors closes #7185 --- Changelog.md | 1 + spec/javascripts/onerror-fail.js | 7 +++++++ spec/javascripts/support/jasmine.yml | 1 + 3 files changed, 9 insertions(+) create mode 100644 spec/javascripts/onerror-fail.js diff --git a/Changelog.md b/Changelog.md index d5df0dfd4..f4f8d6e42 100644 --- a/Changelog.md +++ b/Changelog.md @@ -3,6 +3,7 @@ ## Refactor * Use string-direction gem for rtl detection [#7181](https://github.com/diaspora/diaspora/pull/7181) * Reduce i18n.load side effects [#7184](https://github.com/diaspora/diaspora/pull/7184) +* Force jasmine fails on syntax errors [#7185](https://github.com/diaspora/diaspora/pull/7185) ## Bug fixes * Fix fetching comments after fetching likes [#7167](https://github.com/diaspora/diaspora/pull/7167) diff --git a/spec/javascripts/onerror-fail.js b/spec/javascripts/onerror-fail.js new file mode 100644 index 000000000..21f69b745 --- /dev/null +++ b/spec/javascripts/onerror-fail.js @@ -0,0 +1,7 @@ +window.onerror = function(errorMsg, url, lineNumber) { + describe("Test suite", function() { + it("shouldn't skip tests because of syntax errors", function() { + fail(errorMsg + " in file " + url + " in line " + lineNumber); + }); + }); +}; diff --git a/spec/javascripts/support/jasmine.yml b/spec/javascripts/support/jasmine.yml index 87e516cca..cec433307 100644 --- a/spec/javascripts/support/jasmine.yml +++ b/spec/javascripts/support/jasmine.yml @@ -53,6 +53,7 @@ helpers: # - **/*[sS]pec.js # spec_files: + - onerror-fail.js - "**/**/*[sS]pec.js" # src_dir