diff --git a/app/models/services/facebook.rb b/app/models/services/facebook.rb index 75af8557d..a7ae2b5e4 100644 --- a/app/models/services/facebook.rb +++ b/app/models/services/facebook.rb @@ -8,12 +8,8 @@ class Services::Facebook < Service def post(post, url='') Rails.logger.debug("event=post_to_service type=facebook sender_id=#{self.user_id}") message = public_message(post, url) - begin - post_params = self.create_post_params(message) - Faraday.post("https://graph.facebook.com/me/feed", post_params.to_param) - rescue => e - Rails.logger.info("#{e.message} failed to post to facebook") - end + post_params = self.create_post_params(message) + Faraday.post("https://graph.facebook.com/me/feed", post_params.to_param) end def create_post_params(message) diff --git a/app/models/services/twitter.rb b/app/models/services/twitter.rb index 4ce2d038d..6305aa8f4 100644 --- a/app/models/services/twitter.rb +++ b/app/models/services/twitter.rb @@ -14,11 +14,7 @@ class Services::Twitter < Service configure_twitter - begin - Twitter.update(message) - rescue => e - Rails.logger.info e.message - end + Twitter.update(message) end diff --git a/spec/models/services/facebook_spec.rb b/spec/models/services/facebook_spec.rb index b638a591c..f6ae54c8f 100644 --- a/spec/models/services/facebook_spec.rb +++ b/spec/models/services/facebook_spec.rb @@ -16,6 +16,7 @@ describe Services::Facebook do end it 'swallows exception raised by facebook always being down' do + pending stub_request(:post,"https://graph.facebook.com/me/feed"). to_raise(StandardError) @service.post(@post) diff --git a/spec/models/services/twitter_spec.rb b/spec/models/services/twitter_spec.rb index ec8129bde..e990a3175 100644 --- a/spec/models/services/twitter_spec.rb +++ b/spec/models/services/twitter_spec.rb @@ -16,6 +16,7 @@ describe Services::Twitter do end it 'swallows exception raised by twitter always being down' do + pending Twitter.should_receive(:update).and_raise(StandardError) @service.post(@post) end