diff --git a/app/helpers/open_graph_helper.rb b/app/helpers/open_graph_helper.rb index 3226a5862..ad200af3d 100644 --- a/app/helpers/open_graph_helper.rb +++ b/app/helpers/open_graph_helper.rb @@ -59,7 +59,7 @@ module OpenGraphHelper end def oembed_image_tag(cache, prefix) - image_tag(cache.data[prefix + 'url'], cache.options_hash(prefix)) + image_tag(cache.data["#{prefix}url"], cache.options_hash(prefix)) end private diff --git a/app/models/open_graph_cache.rb b/app/models/open_graph_cache.rb index 71ca83982..8ec435719 100644 --- a/app/models/open_graph_cache.rb +++ b/app/models/open_graph_cache.rb @@ -29,17 +29,15 @@ class OpenGraphCache < ActiveRecord::Base def fetch_and_save_opengraph_data! response = OpenGraph.new(self.url) - if response.blank? || response.type.blank? - return - end - rescue - # noop - else + + return if response.blank? || response.type.blank? + self.title = response.title self.ob_type = response.type self.image = response.images[0] self.url = response.url self.description = response.description + self.save end end