nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Conversations API Test Removed 'convo' Abbreviations

Browse source
This commit is contained in:
Hank Grabowski 2018-11-08 12:58:03 -05:00 committed by Frank Rousseau
parent 4923338bcf
commit 45c8277f2f
1 changed files with 15 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
spec/integration/api/conversations_controller_spec.rb
View file

@ -39,58 +39,58 @@ describe Api::V1::ConversationsController do
end end
it "fails with missing subject " do it "fails with missing subject " do
incomplete_convo = { incomplete_conversation = {
body: "first message", body: "first message",
recipients: [alice.guid], recipients: [alice.guid],
access_token: access_token access_token: access_token
} }
post api_v1_conversations_path, params: incomplete_convo post api_v1_conversations_path, params: incomplete_conversation
expect(response.status).to eq 422 expect(response.status).to eq 422
expect(response.body).to eq(I18n.t("api.endpoint_errors.conversations.cant_process")) expect(response.body).to eq(I18n.t("api.endpoint_errors.conversations.cant_process"))
end end
it "fails with missing body " do it "fails with missing body " do
incomplete_convo = { incomplete_conversation = {
subject: "new conversation", subject: "new conversation",
recipients: [alice.guid], recipients: [alice.guid],
access_token: access_token access_token: access_token
} }
post api_v1_conversations_path, params: incomplete_convo post api_v1_conversations_path, params: incomplete_conversation
expect(response.status).to eq 422 expect(response.status).to eq 422
expect(response.body).to eq(I18n.t("api.endpoint_errors.conversations.cant_process")) expect(response.body).to eq(I18n.t("api.endpoint_errors.conversations.cant_process"))
end end
it "fails with missing recipients " do it "fails with missing recipients " do
incomplete_convo = { incomplete_conversation = {
subject: "new conversation", subject: "new conversation",
body: "first message", body: "first message",
access_token: access_token access_token: access_token
} }
post api_v1_conversations_path, params: incomplete_convo post api_v1_conversations_path, params: incomplete_conversation
expect(response.status).to eq 422 expect(response.status).to eq 422
expect(response.body).to eq(I18n.t("api.endpoint_errors.conversations.cant_process")) expect(response.body).to eq(I18n.t("api.endpoint_errors.conversations.cant_process"))
end end
it "fails with bad recipient ID " do it "fails with bad recipient ID " do
incomplete_convo = { incomplete_conversation = {
subject: "new conversation", subject: "new conversation",
body: "first message", body: "first message",
recipients: JSON.generate(["999_999_999"]), recipients: JSON.generate(["999_999_999"]),
access_token: access_token access_token: access_token
} }
post api_v1_conversations_path, params: incomplete_convo post api_v1_conversations_path, params: incomplete_conversation
expect(response.status).to eq 422 expect(response.status).to eq 422
expect(response.body).to eq(I18n.t("api.endpoint_errors.conversations.cant_process")) expect(response.body).to eq(I18n.t("api.endpoint_errors.conversations.cant_process"))
end end
it "fails with invalid recipient (not allowed to message) " do it "fails with invalid recipient (not allowed to message) " do
incomplete_convo = { incomplete_conversation = {
subject: "new conversation", subject: "new conversation",
body: "first message", body: "first message",
recipients: JSON.generate([eve.guid]), recipients: JSON.generate([eve.guid]),
access_token: access_token access_token: access_token
} }
post api_v1_conversations_path, params: incomplete_convo post api_v1_conversations_path, params: incomplete_conversation
expect(response.status).to eq 422 expect(response.status).to eq 422
expect(response.body).to eq(I18n.t("api.endpoint_errors.conversations.cant_process")) expect(response.body).to eq(I18n.t("api.endpoint_errors.conversations.cant_process"))
end end
@ -115,9 +115,9 @@ describe Api::V1::ConversationsController do
it "returns all the user conversations" do it "returns all the user conversations" do
get api_v1_conversations_path, params: {access_token: access_token} get api_v1_conversations_path, params: {access_token: access_token}
expect(response.status).to eq 200 expect(response.status).to eq 200
returned_convos = JSON.parse(response.body) returned_conversations = JSON.parse(response.body)
expect(returned_convos.length).to eq 3 expect(returned_conversations.length).to eq 3
confirm_conversation_format(returned_convos[0], @conversation, [auth.user, alice]) confirm_conversation_format(returned_conversations[0], @conversation, [auth.user, alice])
end end
it "returns all the user unread conversations" do it "returns all the user unread conversations" do
@ -252,10 +252,10 @@ describe Api::V1::ConversationsController do
private private
# rubocop:disable Metrics/AbcSize # rubocop:disable Metrics/AbcSize
def confirm_conversation_format(conversation, ref_convo, ref_participants) def confirm_conversation_format(conversation, ref_conversation, ref_participants)
expect(conversation["guid"]).to_not be_nil expect(conversation["guid"]).to_not be_nil
conversation_service.find!(conversation["guid"]) conversation_service.find!(conversation["guid"])
expect(conversation["subject"]).to eq ref_convo[:subject] expect(conversation["subject"]).to eq ref_conversation[:subject]
expect(conversation["created_at"]).to_not be_nil expect(conversation["created_at"]).to_not be_nil
expect(conversation["read"]).to be_truthy expect(conversation["read"]).to be_truthy
expect(conversation["participants"].length).to eq(ref_participants.length) expect(conversation["participants"].length).to eq(ref_participants.length)