diff --git a/Changelog.md b/Changelog.md index f70769f50..1ec5fb95e 100644 --- a/Changelog.md +++ b/Changelog.md @@ -7,6 +7,7 @@ * Fix only sharing flag for contacts that are receiving [#5848](https://github.com/diaspora/diaspora/pull/5848) ## Features +* Hide post title of limited post in comment notification email [#5843](https://github.com/diaspora/diaspora/pull/5843) # 0.5.0.0 diff --git a/app/mailers/notification_mailers/comment_on_post.rb b/app/mailers/notification_mailers/comment_on_post.rb index de01804bb..1ad0a5f0f 100644 --- a/app/mailers/notification_mailers/comment_on_post.rb +++ b/app/mailers/notification_mailers/comment_on_post.rb @@ -6,7 +6,11 @@ module NotificationMailers @comment = Comment.find(comment_id) @headers[:from] = "\"#{@comment.author_name} (diaspora*)\" <#{AppConfig.mail.sender_address}>" - @headers[:subject] = "Re: #{@comment.comment_email_subject}" + if @comment.public? + @headers[:subject] = "Re: #{@comment.comment_email_subject}" + else + @headers[:subject] = I18n.t("notifier.comment_on_post.limited_subject") + end end end end diff --git a/config/locales/diaspora/en.yml b/config/locales/diaspora/en.yml index 11f51b90f..2f26d3ad3 100644 --- a/config/locales/diaspora/en.yml +++ b/config/locales/diaspora/en.yml @@ -743,6 +743,7 @@ en: sharing: "has started sharing with you!" view_profile: "View %{name}’s profile" comment_on_post: + limited_subject: "There's a new comment on a post you commented" reply: "Reply or view %{name}’s post >" mentioned: subject: "%{name} has mentioned you on diaspora*" diff --git a/spec/mailers/notifier_spec.rb b/spec/mailers/notifier_spec.rb index ce99f6a15..c9a0ad9d5 100644 --- a/spec/mailers/notifier_spec.rb +++ b/spec/mailers/notifier_spec.rb @@ -318,6 +318,26 @@ describe Notifier, :type => :mailer do end end + context "limited comments" do + let(:commented_limited_post) { + bob.post(:status_message, to: :all, public: false, + text: "### Limited headline \r\n It's **really** sunny outside today") + } + let(:limited_comment) { eve.comment!(commented_limited_post, "Totally is") } + + describe ".comment_on_limited_post" do + let(:limited_comment_mail) { Notifier.comment_on_post(bob.id, person.id, limited_comment.id).deliver_now } + + it "SUBJECT: does not show limited message" do + expect(limited_comment_mail.subject).not_to include("Limited headline") + end + + it "BODY: does not show limited message" do + expect(limited_comment_mail.body.encoded).not_to include("Limited headline") + end + end + end + describe 'hashtags' do it 'escapes hashtags' do mails = Notifier.admin("#Welcome to bureaucracy!", [bob])