diff --git a/app/models/api/openid_connect/o_auth_application.rb b/app/models/api/openid_connect/o_auth_application.rb index 6ade4b9a8..fc8482b53 100644 --- a/app/models/api/openid_connect/o_auth_application.rb +++ b/app/models/api/openid_connect/o_auth_application.rb @@ -6,7 +6,7 @@ module Api validates :client_id, presence: true, uniqueness: true validates :client_secret, presence: true - validates :client_name, presence: true, uniqueness: {scope: :redirect_uris} + validates :client_name, uniqueness: {scope: :redirect_uris} %i(redirect_uris response_types grant_types contacts).each do |serializable| serialize serializable, JSON diff --git a/spec/controllers/api/openid_connect/clients_controller_spec.rb b/spec/controllers/api/openid_connect/clients_controller_spec.rb index 159a0059f..618909d69 100644 --- a/spec/controllers/api/openid_connect/clients_controller_spec.rb +++ b/spec/controllers/api/openid_connect/clients_controller_spec.rb @@ -24,17 +24,6 @@ describe Api::OpenidConnect::ClientsController, type: :controller do expect(client_json["error"]).to have_content("invalid_client_metadata") end end - - context "when redirect client_name is missing" do - it "should return a invalid_client_metadata error" do - post :create, redirect_uris: ["http://localhost"], response_types: [], grant_types: [], - application_type: "web", contacts: [], logo_uri: "http://example.com/logo.png", - client_uri: "http://example.com/client", policy_uri: "http://example.com/policy", - tos_uri: "http://example.com/tos" - client_json = JSON.parse(response.body) - expect(client_json["error"]).to have_content("invalid_client_metadata") - end - end end describe "#find" do