nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve contacts page jasmine test

Browse source 
* append html to spec.content() instead of body
* don't append the unused conversations modal fixture
* actually test that showModal has been called
This commit is contained in:
Steffen van Bergerem 2016-11-13 15:49:11 +01:00 committed by Benjamin Neff
parent 9cbadec659
commit 4c86b64532
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
spec/javascripts/app/pages/contacts_spec.js
View file

@ -280,16 +280,16 @@ describe("app.pages.Contacts", function(){
describe("showMessageModal", function() {
beforeEach(function() {
$("body").append("<div id='conversationModal'/>").append(spec.readFixture("conversations_modal"));
spec.content().append("<div id='conversationModal'/>");
});
it("calls app.helpers.showModal", function() {
spyOn(app.helpers, "showModal");
this.view.showMessageModal();
expect(app.helpers.showModal);
expect(app.helpers.showModal).toHaveBeenCalled();
});
it("app.views.ConversationsForm with correct parameters when modal is loaded", function() {
it("initializes app.views.ConversationsForm with correct parameters when modal is loaded", function() {
gon.conversationPrefill = [
{id: 1, name: "diaspora user", handle: "diaspora-user@pod.tld"},
{id: 2, name: "other diaspora user", handle: "other-diaspora-user@pod.tld"},
@ -299,7 +299,6 @@ describe("app.pages.Contacts", function(){
spyOn(app.views.ConversationsForm.prototype, "initialize");
this.view.showMessageModal();
$("#conversationModal").trigger("modal:loaded");
expect($("#conversationModal").length).toBe(1);
expect(app.views.ConversationsForm.prototype.initialize)
.toHaveBeenCalledWith({prefill: gon.conversationPrefill});
});