nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix missing photos in the single post view

Browse source 
closes #7545
This commit is contained in:
Steffen van Bergerem 2017-08-17 01:02:06 +02:00 committed by Benjamin Neff
parent b49b33675f
commit 4cb365a6f4
No known key found for this signature in database
GPG key ID: 971464C3F1A90194
2 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
app/assets/javascripts/app/views/content_view.js
View file

@ -17,15 +17,14 @@ app.views.Content = app.views.Base.extend({
largePhoto : function() { largePhoto : function() {
var photos = this.model.get("photos"); var photos = this.model.get("photos");
if(!photos || photos.length === 0) { return } if (!photos || photos.length === 0) { return false; }
return photos[0]; return photos[0];
}, },
smallPhotos : function() { smallPhotos : function() {
var photos = this.model.get("photos"); var photos = this.model.get("photos");
if(!photos || photos.length < 2) { return } if (!photos || photos.length < 2) { return false; }
photos.splice(0, 1); // remove first photo as it is already shown as largePhoto return photos.slice(1); // remove first photo as it is already shown as largePhoto
return photos;
}, },
expandPost: function(evt) { expandPost: function(evt) {

8
spec/javascripts/app/views/content_view_spec.js
View file

@ -4,11 +4,17 @@ describe("app.views.Content", function(){
this.view = new app.views.Content({model : this.post}); this.view = new app.views.Content({model : this.post});
}); });
describe("rendering", function(){ describe("smallPhotos", function() {
it("should return all but the first photo from the post", function() { it("should return all but the first photo from the post", function() {
this.post.set({photos : [1,2]}); // set 2 Photos this.post.set({photos : [1,2]}); // set 2 Photos
expect(this.view.smallPhotos().length).toEqual(1); expect(this.view.smallPhotos().length).toEqual(1);
}); });
it("shouldn't change the photos array", function() {
this.post.set({photos: [1, 2]}); // set 2 Photos
this.view.smallPhotos();
expect(this.post.get("photos").length).toEqual(2);
});
}); });
describe("presenter", function(){ describe("presenter", function(){