From 4e6d92ce63c96d577cef04e338bed8a17372b635 Mon Sep 17 00:00:00 2001 From: Benjamin Neff Date: Thu, 12 Oct 2017 04:38:56 +0200 Subject: [PATCH] Remove wrapping transaction for account deletion This uses a lot of memory for big accounts. Also it doesn't make much sense to rollback everything when something fails, it's better to delete everything we can. --- lib/account_deleter.rb | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/lib/account_deleter.rb b/lib/account_deleter.rb index d7ca63d1d..b14582980 100644 --- a/lib/account_deleter.rb +++ b/lib/account_deleter.rb @@ -25,17 +25,15 @@ class AccountDeleter end def perform! - ActiveRecord::Base.transaction do - #person - delete_standard_person_associations - remove_conversation_visibilities - delete_contacts_of_me - tombstone_person_and_profile + # close person + delete_standard_person_associations + remove_conversation_visibilities + delete_contacts_of_me + tombstone_person_and_profile - close_user if user + close_user if user - mark_account_deletion_complete - end + mark_account_deletion_complete end # user deletion methods