nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Web mobile notificacions count dont change to unread-read when click in link post

Browse source
This commit is contained in:
movilla 2012-11-10 23:25:18 +01:00
parent 10aea3ebce
commit 554fe40235
3 changed files with 6 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Changelog.md
View file

@ -39,6 +39,7 @@
* Fix error with invite link box shows on search results page even if invites have been turned off. [#3708](https://github.com/diaspora/diaspora/pull/3708)
* Fix misconfiguration of Devise to allow the session to be remembered. [#3472](https://github.com/diaspora/diaspora/issues/3472)
* Fix problem with show reshares_count in stream. [#3700](https://github.com/diaspora/diaspora/pull/3700)
* Fix error with notifications count in mobile. [#3721](https://github.com/diaspora/diaspora/pull/3721)
# 0.0.1.2

2
app/controllers/posts_controller.rb
View file

@ -105,7 +105,7 @@ class PostsController < ApplicationController
end
def mark_corresponding_notification_read
if notification = Notification.where(:recipient_id => current_user.id, :target_id => @post.id).first
if notification = Notification.where(:recipient_id => current_user.id, :target_id => @post.id, :unread => true).first
notification.unread = false
notification.save
end

14
spec/controllers/posts_controller_spec.rb
View file

@ -41,22 +41,16 @@ describe PostsController do
end
it 'marks a corresponding notification as read' do
note = Notification.create(:recipient => alice, :target => @message, :unread => true)
# Ensure that it doesn't mark a read notification as read
FactoryGirl.create(:notification, :recipient => alice, :target => @message, :unread => false)
note = FactoryGirl.create(:notification, :recipient => alice, :target => @message, :unread => true)
lambda{
expect {
get :show, :id => @message.id
note.reload
}.should change(note, :unread).from(true).to(false)
end
it 'change from unread to read a corresponding notification' do
FactoryGirl.create(:notification, :target => @message, :recipient => alice, :unread => true)
FactoryGirl.create(:notification, :recipient => alice, :unread => false)
Notification.where(:unread => true).count.should == 1
get :show, :id => @message.id
Notification.where(:unread => true).count.should == 0
end
it 'succeeds with a AS/photo' do
photo = FactoryGirl.create(:activity_streams_photo, :author => bob.person)
get :show, :id => photo.id