nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't overwrite app.stream properties in tests

Browse source 
These cases of modifying app.stream can cause other specs to fail, depending on test order. Here we either don't modify them if the tests still pass without manually stubbing `addNow`, or we cache and restore the properties we need to test.
This commit is contained in:
Sage Ross 2022-01-02 17:09:16 -08:00 committed by Benjamin Neff
parent f4234fa3a0
commit 56ef83fa8a
No known key found for this signature in database
GPG key ID: 971464C3F1A90194
2 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
spec/javascripts/app/models/post/interacations_spec.js
View file

@ -122,9 +122,11 @@ describe("app.models.Post.Interactions", function(){
});
it("adds the reshare to the default, activity and aspects stream", function() {
app.stream = { addNow: $.noop };
app.stream = new app.models.Stream(_, { basePath: "/aspects/all" });
spyOn(app.stream, "addNow");
var self = this;
["/stream", "/activity", "/aspects"].forEach(function(path) {
app.stream.basePath = function() { return path; };
self.interactions.reshare();
@ -132,10 +134,13 @@ describe("app.models.Post.Interactions", function(){
expect(app.stream.addNow).toHaveBeenCalledWith({id: 1});
});
new app.models.Stream(_, { basePath: "/aspects/all" });
});
it("doesn't add the reshare to any other stream", function() {
app.stream = { addNow: $.noop };
app.stream = new app.models.Stream(_, { basePath: "/aspects/all" });
spyOn(app.stream, "addNow");
var self = this;
["/followed_tags", "/mentions/", "/tag/diaspora", "/people/guid/stream"].forEach(function(path) {
@ -144,6 +149,8 @@ describe("app.models.Post.Interactions", function(){
jasmine.Ajax.requests.mostRecent().respondWith(ajaxSuccess);
expect(app.stream.addNow).not.toHaveBeenCalled();
});
new app.models.Stream(_, { basePath: "/aspects/all" });
});
it("sets the participation flag for the post", function() {

6
spec/javascripts/app/views/publisher_view_spec.js
View file

@ -25,7 +25,8 @@ describe("app.views.Publisher", function() {
describe("createStatusMessage", function(){
it("doesn't add the status message to the stream", function() {
app.stream = { addNow: $.noop };
app.stream = new app.models.Stream();
spyOn(app.stream, "addNow");
this.view.createStatusMessage($.Event());
jasmine.Ajax.requests.mostRecent().respondWith({ status: 200, responseText: "{\"id\": 1}" });
@ -198,7 +199,8 @@ describe("app.views.Publisher", function() {
describe("createStatusMessage", function(){
it("adds the status message to the stream", function() {
app.stream = { addNow: $.noop };
new app.models.Stream();
spyOn(app.stream, "addNow");
this.view.createStatusMessage($.Event());
jasmine.Ajax.requests.mostRecent().respondWith({ status: 200, responseText: "{\"id\": 1}" });