From f1d6e9440b9786ab315b4b1ba66c16965a876958 Mon Sep 17 00:00:00 2001 From: Anton Tkachov Date: Wed, 5 Aug 2015 00:55:34 +0300 Subject: [PATCH] Issue #6281: add url to hovercard avatar closes #6297 --- Changelog.md | 1 + app/assets/javascripts/app/views/hovercard_view.js | 2 ++ app/assets/templates/hovercard_tpl.jst.hbs | 4 +++- 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Changelog.md b/Changelog.md index 7b25f248d..3f4bdbce1 100644 --- a/Changelog.md +++ b/Changelog.md @@ -19,6 +19,7 @@ * Implement NodeInfo [#6239](https://github.com/diaspora/diaspora/pull/6239) * Display original author on reshares of NSFW posts [#6270](https://github.com/diaspora/diaspora/pull/6270) +* Use avatars in hovercards as links to the profile [#6297](https://github.com/diaspora/diaspora/pull/6297) # 0.5.2.0 diff --git a/app/assets/javascripts/app/views/hovercard_view.js b/app/assets/javascripts/app/views/hovercard_view.js index cfcf49762..41b5f587a 100644 --- a/app/assets/javascripts/app/views/hovercard_view.js +++ b/app/assets/javascripts/app/views/hovercard_view.js @@ -20,6 +20,7 @@ app.views.Hovercard = app.views.Base.extend({ // cache some element references this.avatar = this.$('.avatar'); + this.avatarLink = this.$("a.person_avatar"); this.dropdown = this.$('.dropdown_list'); this.dropdown_container = this.$('#hovercard_dropdown_container'); this.hashtags = this.$('.hashtags'); @@ -115,6 +116,7 @@ app.views.Hovercard = app.views.Base.extend({ var self = this; this.avatar.attr('src', person.avatar); + this.avatarLink.attr("href", person.url); this.person_link.attr('href', person.url); this.person_link.text(person.name); this.person_handle.text(person.handle); diff --git a/app/assets/templates/hovercard_tpl.jst.hbs b/app/assets/templates/hovercard_tpl.jst.hbs index 7070a36f4..32908a080 100644 --- a/app/assets/templates/hovercard_tpl.jst.hbs +++ b/app/assets/templates/hovercard_tpl.jst.hbs @@ -1,5 +1,7 @@
- + + +