Fix statistics_presenter_spec

This commit is contained in:
Jonne Haß 2014-10-02 22:22:03 +03:00 committed by Jason Robinson
parent 309e690a66
commit 66c2f7f869
3 changed files with 22 additions and 9 deletions

View file

@ -17,8 +17,8 @@ class StatisticsPresenter
if AppConfig.privacy.statistics.comment_counts? if AppConfig.privacy.statistics.comment_counts?
result['local_comments'] = self.local_comments result['local_comments'] = self.local_comments
end end
AppConfig.services.each do |service, options| Configuration::KNOWN_SERVICES.each do |service, options|
result[service] = AppConfig["services.#{service}.enable"] result[service.to_s] = AppConfig["services.#{service}.enable"]
end end
result result

View file

@ -1,4 +1,6 @@
module Configuration module Configuration
KNOWN_SERVICES = [:twitter, :tumblr, :facebook, :wordpress].freeze
module Methods module Methods
def pod_uri def pod_uri
return @pod_uri unless @pod_uri.nil? return @pod_uri unless @pod_uri.nil?
@ -24,7 +26,7 @@ module Configuration
return @configured_services unless @configured_services.nil? return @configured_services unless @configured_services.nil?
@configured_services = [] @configured_services = []
[:twitter, :tumblr, :facebook, :wordpress].each do |service| KNOWN_SERVICES.each do |service|
@configured_services << service if services.send(service).enable? @configured_services << service if services.send(service).enable?
end end

View file

@ -13,11 +13,17 @@ describe StatisticsPresenter do
end end
describe '#statistics contents' do describe '#statistics contents' do
before do
it 'provides generic pod data in json' do
AppConfig.privacy.statistics.user_counts = false AppConfig.privacy.statistics.user_counts = false
AppConfig.privacy.statistics.post_counts = false AppConfig.privacy.statistics.post_counts = false
AppConfig.privacy.statistics.comment_counts = false AppConfig.privacy.statistics.comment_counts = false
end
after do
AppConfig.privacy = nil
end
it 'provides generic pod data in json' do
expect(@presenter.as_json).to eq({ expect(@presenter.as_json).to eq({
"name" => AppConfig.settings.pod_name, "name" => AppConfig.settings.pod_name,
"version" => AppConfig.version_string, "version" => AppConfig.version_string,
@ -42,6 +48,11 @@ describe StatisticsPresenter do
} }
end end
after do
AppConfig.services = nil
AppConfig.privacy = nil
end
it 'provides generic pod data and counts in json' do it 'provides generic pod data and counts in json' do
expect(@presenter.as_json).to eq({ expect(@presenter.as_json).to eq({
"name" => AppConfig.settings.pod_name, "name" => AppConfig.settings.pod_name,