nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove unnecessary execute_script call in feature spec

Browse source 
This call to `execute_script` would directly call jQuery's `sortable` function on an element to make it sortable. However, this isn't necessary; the test can still drag the "Cat People" aspect to the desired position without it.
This commit is contained in:
Sage Ross 2021-12-30 13:27:48 -08:00 committed by Benjamin Neff
parent 245bc1a05f
commit 688245c0de
No known key found for this signature in database
GPG key ID: 971464C3F1A90194
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
features/step_definitions/aspects_steps.rb
View file

@ -119,8 +119,6 @@ When /^(.*) in the aspect creation modal$/ do |action|
end end
When /^I drag "([^"]*)" (up|down)$/ do |aspect_name, direction| When /^I drag "([^"]*)" (up|down)$/ do |aspect_name, direction|
expect(page).to have_js_defined("$('body').sortable")
page.execute_script("$('#aspect_nav .list-group').sortable('option', 'tolerance', 'pointer');")
aspect_id = @me.aspects.where(name: aspect_name).first.id aspect_id = @me.aspects.where(name: aspect_name).first.id
aspect = find(:xpath, "//div[@id='aspect_nav']/ul/a[@data-aspect-id='#{aspect_id}']") aspect = find(:xpath, "//div[@id='aspect_nav']/ul/a[@data-aspect-id='#{aspect_id}']")
target = direction == "up" ? aspect.all(:xpath, "./preceding-sibling::a").last : target = direction == "up" ? aspect.all(:xpath, "./preceding-sibling::a").last :