nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add mobile comment box only once

Browse source
This commit is contained in:
Steffen van Bergerem 2015-08-29 15:18:11 +02:00
parent cd602c19fd
commit 696eebbe5d
2 changed files with 60 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
app/assets/javascripts/mobile/mobile_comments.js
View file

@ -24,7 +24,7 @@
$(".stream").on("tap click", "a.comment-action", function(evt) { $(".stream").on("tap click", "a.comment-action", function(evt) {
evt.preventDefault(); evt.preventDefault();
self.showCommentBox(this); self.showCommentBox($(this));
var bottomBar = $(this).closest(".bottom_bar").first(); var bottomBar = $(this).closest(".bottom_bar").first();
var commentContainer = bottomBar.find(".comment_container").first(); var commentContainer = bottomBar.find(".comment_container").first();
self.scrollToOffset(commentContainer); self.scrollToOffset(commentContainer);
@ -110,20 +110,21 @@
}, },
showCommentBox: function(link){ showCommentBox: function(link){
var commentActionLink = $(link); if(!link.hasClass("inactive") || link.hasClass("loading")) { return; }
var self = this; var self = this;
if(commentActionLink.hasClass("inactive")) {
$.ajax({ $.ajax({
url: commentActionLink.attr("href"), url: link.attr("href"),
beforeSend: function(){ beforeSend: function(){
commentActionLink.addClass("loading"); link.addClass("loading");
}, },
context: commentActionLink, context: link,
success: function(data){ success: function(data) {
self.appendCommentBox.call(this, commentActionLink, data); self.appendCommentBox.call(this, link, data);
},
error: function() {
link.removeClass("loading");
} }
}); });
}
}, },
appendCommentBox: function(link, data) { appendCommentBox: function(link, data) {

45
spec/javascripts/mobile/mobile_comments_spec.js
View file

@ -71,4 +71,49 @@ describe("Diaspora.Mobile.Comments", function(){
expect($(".stream .stream_element").first()).toContainElement(".commentContainerForTest"); expect($(".stream .stream_element").first()).toContainElement(".commentContainerForTest");
}); });
}); });
describe("showCommentBox", function() {
beforeEach(function() {
spec.loadFixture("aspects_index_mobile_post_with_comments");
this.link = $(".stream .comment-action").first();
});
it("adds the 'loading' class to the link", function() {
Diaspora.Mobile.Comments.showCommentBox(this.link);
expect($(".comment-action").first()).toHaveClass("loading");
});
it("removes the 'loading' class if the request failed", function() {
Diaspora.Mobile.Comments.showCommentBox(this.link);
jasmine.Ajax.requests.mostRecent().respondWith({status: 400});
expect($(".comment-action").first()).not.toHaveClass("loading");
});
it("fires an AJAX call", function() {
spyOn(jQuery, "ajax");
Diaspora.Mobile.Comments.showCommentBox(this.link);
expect(jQuery.ajax).toHaveBeenCalled();
});
it("calls appendCommentBox", function() {
spyOn(Diaspora.Mobile.Comments, "appendCommentBox");
Diaspora.Mobile.Comments.showCommentBox(this.link);
jasmine.Ajax.requests.mostRecent().respondWith({status: 200, contentType: "text/plain", responseText: "test"});
expect(Diaspora.Mobile.Comments.appendCommentBox).toHaveBeenCalledWith(this.link, "test");
});
it("doesn't do anything if the link class is 'loading'", function() {
spyOn(jQuery, "ajax");
this.link.addClass("loading");
Diaspora.Mobile.Comments.showCommentBox(this.link);
expect(jQuery.ajax).not.toHaveBeenCalled();
});
it("doesn't do anything if the link class is not 'inactive'", function() {
spyOn(jQuery, "ajax");
this.link.removeClass("inactive");
Diaspora.Mobile.Comments.showCommentBox(this.link);
expect(jQuery.ajax).not.toHaveBeenCalled();
});
});
}); });