From 6a51c09a16069b55236c5fa4b103719dd126ff7c Mon Sep 17 00:00:00 2001
From: danielgrippi <daniel@joindiaspora.com>
Date: Tue, 29 Mar 2011 17:30:02 -0700
Subject: [PATCH] delete bad post visibilities before traversing the table

---
 .../20110328202414_post_visibilities_on_contacts.rb | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/db/migrate/20110328202414_post_visibilities_on_contacts.rb b/db/migrate/20110328202414_post_visibilities_on_contacts.rb
index ce08350d6..106bf2d50 100644
--- a/db/migrate/20110328202414_post_visibilities_on_contacts.rb
+++ b/db/migrate/20110328202414_post_visibilities_on_contacts.rb
@@ -27,8 +27,6 @@ SQL
   end
 
   def self.delete_duplicate_pvs
-    execute('DELETE FROM post_visibilities WHERE post_visibilities.contact_id = 0')
-
     duplicate_rows = execute <<SQL
       SELECT COUNT(pv.contact_id), pv.contact_id, pv.post_id from post_visibilities AS pv
         GROUP BY pv.contact_id, pv.post_id
@@ -47,6 +45,15 @@ SQL
     end
   end
 
+  def self.delete_disconnected_pvs
+    execute <<SQL
+    DELETE post_visibilities FROM post_visibilities
+      LEFT OUTER JOIN posts ON post_visibilities.post_id = posts.id
+      LEFT OUTER JOIN aspects ON post_visibilities.aspect_id = aspects.id
+    WHERE aspects.id IS NULL OR posts.id IS NULL
+SQL
+  end
+
   def self.up
     create_table :aspect_visibilities do |t|
       t.integer :post_id, :null => false
@@ -59,6 +66,8 @@ SQL
     add_foreign_key :aspect_visibilities, :aspects, :dependent => :delete
     add_foreign_key :aspect_visibilities, :posts, :dependent => :delete
 
+    delete_disconnected_pvs
+
     add_column :post_visibilities, :contact_id, :integer, :null => false
 
     move_author_pvs_to_aspect_pvs