From f4ff48f5c0d7b94e96ed5a16295c04df2943d336 Mon Sep 17 00:00:00 2001 From: maxwell Date: Mon, 22 Nov 2010 10:26:00 -0800 Subject: [PATCH 1/3] commenting out mobile for now. photos now post from only a users photos --- app/controllers/application_controller.rb | 4 ++-- app/controllers/status_messages_controller.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index 1fe536c89..e6ba2f67f 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -3,10 +3,10 @@ # the COPYRIGHT file. class ApplicationController < ActionController::Base - has_mobile_fu + #has_mobile_fu protect_from_forgery :except => :receive - before_filter :mobile_except_ipad + # =>before_filter :mobile_except_ipad before_filter :set_contacts_and_status, :except => [:create, :update] before_filter :count_requests before_filter :set_invites diff --git a/app/controllers/status_messages_controller.rb b/app/controllers/status_messages_controller.rb index 8e8f3c8a3..54487dbeb 100644 --- a/app/controllers/status_messages_controller.rb +++ b/app/controllers/status_messages_controller.rb @@ -9,7 +9,7 @@ class StatusMessagesController < ApplicationController respond_to :json, :only => :show def create - photos = Photo.all(:id.in => [*params[:photos]]) + photos = Photo.all(:id.in => [*params[:photos]], :diaspora_handle => current_user.person.diaspora_handle) public_flag = params[:status_message][:public] public_flag.to_s.match(/(true)/) ? public_flag = true : public_flag = false From 857a4b5f112088afd81504776431ae1e687c3dd9 Mon Sep 17 00:00:00 2001 From: danielvincent Date: Mon, 22 Nov 2010 10:31:59 -0800 Subject: [PATCH 2/3] photo large is now at 300px. a person's profile photo now references the larger size instead of medium. --- app/controllers/dev_utilities_controller.rb | 2 +- app/controllers/people_controller.rb | 2 +- app/models/photo.rb | 2 +- app/uploaders/image_uploader.rb | 2 +- app/views/photos/show.html.haml | 2 +- public/javascripts/view.js | 2 ++ spec/models/photo_spec.rb | 2 +- spec/models/profile_spec.rb | 8 ++++---- 8 files changed, 12 insertions(+), 10 deletions(-) diff --git a/app/controllers/dev_utilities_controller.rb b/app/controllers/dev_utilities_controller.rb index 8eb7b788c..d0c6320da 100644 --- a/app/controllers/dev_utilities_controller.rb +++ b/app/controllers/dev_utilities_controller.rb @@ -69,7 +69,7 @@ class DevUtilitiesController < ApplicationController current_user.raw_visible_posts << photo current_user.save - current_user.update_profile(:image_url => photo.url(:thumb_medium)) + current_user.update_profile(:image_url => photo.url(:thumb_large)) current_user.save end diff --git a/app/controllers/people_controller.rb b/app/controllers/people_controller.rb index e67d794c8..93ff34e87 100644 --- a/app/controllers/people_controller.rb +++ b/app/controllers/people_controller.rb @@ -76,7 +76,7 @@ class PeopleController < ApplicationController params[:profile_image_hash] = { :user_file => raw_image, :to => "all" } photo = current_user.post(:photo, params[:profile_image_hash]) - params[:person][:profile][:image_url] = photo.url(:thumb_medium) + params[:person][:profile][:image_url] = photo.url(:thumb_large) end if current_user.update_profile params[:person][:profile] diff --git a/app/models/photo.rb b/app/models/photo.rb index e07422735..46f6286ec 100644 --- a/app/models/photo.rb +++ b/app/models/photo.rb @@ -65,7 +65,7 @@ class Photo < Post end def ensure_user_picture - people = Person.all('profile.image_url' => absolute_url(:thumb_medium) ) + people = Person.all('profile.image_url' => absolute_url(:thumb_large) ) people.each{ |person| person.profile.update_attributes(:image_url => nil) } diff --git a/app/uploaders/image_uploader.rb b/app/uploaders/image_uploader.rb index f94189076..71b842ecc 100644 --- a/app/uploaders/image_uploader.rb +++ b/app/uploaders/image_uploader.rb @@ -30,7 +30,7 @@ class ImageUploader < CarrierWave::Uploader::Base end version :thumb_large do - process :resize_to_fill => [200,200] + process :resize_to_fill => [300,300] end version :scaled_full do diff --git a/app/views/photos/show.html.haml b/app/views/photos/show.html.haml index 6ed450384..8a12ac3be 100644 --- a/app/views/photos/show.html.haml +++ b/app/views/photos/show.html.haml @@ -40,7 +40,7 @@ -if @ownership = image_tag 'ajax-loader.gif', :id => "photo_spinner", :class => "hidden" = image_tag @photo.url(:scaled_full) - .photo_options{:data=>{:actor=>"#{@photo.person.owner.id}",:actor_person=>"#{@photo.person.id}",:image_url=>"#{@photo.url(:thumb_medium)}"}} + .photo_options{:data=>{:actor=>"#{@photo.person.owner.id}",:actor_person=>"#{@photo.person.id}",:image_url=>"#{@photo.url(:thumb_large)}"}} = link_to t('.make_profile_photo'), '#', :class => 'make_profile_photo' | = link_to 'edit', '#', :id => "edit_photo_toggle" diff --git a/public/javascripts/view.js b/public/javascripts/view.js index 15d5fd1ff..41b943b58 100644 --- a/public/javascripts/view.js +++ b/public/javascripts/view.js @@ -136,6 +136,8 @@ function openVideo(type, videoid, link) { link.parentNode.insertBefore(container, this.nextSibling); $container.slideDown('fast', function() { }); link.onclick = function() { $container.slideToggle('fast', function() { } ); } + + } $(".make_profile_photo").live("click", function(evt){ diff --git a/spec/models/photo_spec.rb b/spec/models/photo_spec.rb index 24bbaff4c..95686ab36 100644 --- a/spec/models/photo_spec.rb +++ b/spec/models/photo_spec.rb @@ -82,7 +82,7 @@ describe Photo do it 'should remove its reference in user profile if it is referred' do @photo.save - @user.profile.image_url = @photo.image.url(:thumb_medium) + @user.profile.image_url = @photo.image.url(:thumb_large) @user.person.save @photo.destroy Person.find(@user.person.id).profile.image_url.should be_nil diff --git a/spec/models/profile_spec.rb b/spec/models/profile_spec.rb index 8ce848a85..e74a08c78 100644 --- a/spec/models/profile_spec.rb +++ b/spec/models/profile_spec.rb @@ -55,12 +55,12 @@ describe Profile do lambda {@profile.image_url = ""}.should_not change(@profile, :image_url) end it 'makes relative urls absolute' do - @profile.image_url = @photo.url(:thumb_medium) - @profile.image_url.should == "#{@pod_url}#{@photo.url(:thumb_medium)}" + @profile.image_url = @photo.url(:thumb_large) + @profile.image_url.should == "#{@pod_url}#{@photo.url(:thumb_large)}" end it 'accepts absolute urls' do - @profile.image_url = "#{@pod_url}#{@photo.url(:thumb_medium)}" - @profile.image_url.should == "#{@pod_url}#{@photo.url(:thumb_medium)}" + @profile.image_url = "#{@pod_url}#{@photo.url(:thumb_large)}" + @profile.image_url.should == "#{@pod_url}#{@photo.url(:thumb_large)}" end end describe 'serialization' do From 8c6f3bddc3c5288e4c68e8f860196cbac7d20978 Mon Sep 17 00:00:00 2001 From: danielvincent Date: Mon, 22 Nov 2010 11:19:50 -0800 Subject: [PATCH 3/3] added diaspora handle to home page with help text. added email address to account settings page. --- app/helpers/application_helper.rb | 4 ++++ app/views/aspects/index.html.haml | 7 +++++-- app/views/users/edit.html.haml | 15 ++++++++++++++- public/javascripts/view.js | 1 + public/stylesheets/sass/application.sass | 23 +++++++++++++++++++++++ 5 files changed, 47 insertions(+), 3 deletions(-) diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index 67f78c42e..ea2ccddf4 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -180,4 +180,8 @@ module ApplicationHelper @@youtube_title_cache[id] = ret; return ret end + + def info_text(text) + "?".html_safe + end end diff --git a/app/views/aspects/index.html.haml b/app/views/aspects/index.html.haml index 963e2a7fd..6331458a6 100644 --- a/app/views/aspects/index.html.haml +++ b/app/views/aspects/index.html.haml @@ -3,8 +3,12 @@ -# the COPYRIGHT file. .span-24.last - %h2 + %h2{:style => "position:relative;"} Home + .right + %span.description + = current_user.diaspora_handle + = info_text("This is your diaspora handle. Like an email address, you can give this to people to reach you.") .span-15.last = render 'aspects/no_contacts_message', :aspect => @aspect, :contact_count => @contacts.count @@ -16,7 +20,6 @@ #pagination = will_paginate @posts - .span-8.prepend-1.last = render 'shared/aspect_contacts', :contacts => @contacts, :aspect => @aspect diff --git a/app/views/users/edit.html.haml b/app/views/users/edit.html.haml index 57984a55b..d5dea15a0 100644 --- a/app/views/users/edit.html.haml +++ b/app/views/users/edit.html.haml @@ -24,11 +24,24 @@ %h2 = t('account') - = link_to t('.invite_contacts'), new_user_invitation_path(current_user) + .span-8.append-1.last + %h3 + Your diaspora handle + %p + %b= current_user.diaspora_handle + .span-8.prepend-2.last + %h3 + Your email + %p + = current_user.email %br %br %br + %br + %br + %br + %br %h3 = t('.change_password') diff --git a/public/javascripts/view.js b/public/javascripts/view.js index 41b943b58..f67dc0d7d 100644 --- a/public/javascripts/view.js +++ b/public/javascripts/view.js @@ -81,6 +81,7 @@ $(document).ready(function(){ $(".add_aspect_button", "#aspect_nav").tipsy({gravity:'w'}); $(".person img", ".dropzone").tipsy({live:true}); $(".avatar", ".aspects").tipsy({live:true}); + $(".what_is_this").tipsy({live:true,delayIn:400}); $('.webfinger_form').submit(function(evt){ form = $(evt.currentTarget); diff --git a/public/stylesheets/sass/application.sass b/public/stylesheets/sass/application.sass index 6d2c1da45..4cc044cc5 100644 --- a/public/stylesheets/sass/application.sass +++ b/public/stylesheets/sass/application.sass @@ -1943,3 +1943,26 @@ h3,h4 :-moz-border-radius 5px :border-radius 5px +.what_is_this + :display inline-block + :cursor default + :font + :size 8px + :color #fff + + :background + :color #ccc + + :-webkit-border-radius 10px + + :width 15px + :max-width 12px + :text + :indent 4px + + :position relative + :top -4px + + &:hover + :background + :color #107FC9