nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

For some reason, firefox doesn't like the outerHTML property of this div - it's always undefined. This was manifesting itself as ajax requests never completing in the cucumber feature due to a js error.

Browse source
This commit is contained in:
Sarah Mei 2011-07-31 13:32:05 -07:00
parent f0ecef7f1a
commit 7f81892245
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
features/connects_users.feature
View file

@ -73,7 +73,7 @@ Feature: sending and receiving requests
And I press the first ".toggle.button" And I press the first ".toggle.button"
And I press the first "a" within ".add_aspect" And I press the first "a" within ".add_aspect"
And I wait for the ajax to finish And I wait for the ajax to finish
And I fill in "Name" with "Super People" in the modal window And I fill in "Name" with "Super People" in the modal window
And I press "aspect_submit" in the modal window And I press "aspect_submit" in the modal window
And I wait for the ajax to finish And I wait for the ajax to finish
@ -102,8 +102,9 @@ Feature: sending and receiving requests
And I should not see "Message" And I should not see "Message"
When I add the person to my 1st aspect When I add the person to my 1st aspect
And I wait for the ajax to finish
And I add the person to my 2nd aspect And I add the person to my 2nd aspect
# should wait for ajax to finish here, but infinite scroll is screwing that up. And I wait for the ajax to finish
When I go to "bob@bob.bob"'s page When I go to "bob@bob.bob"'s page
Then I should see "In 2 aspects" Then I should see "In 2 aspects"
And I should see "Mention" And I should see "Mention"

2
public/javascripts/contact-edit.js
View file

@ -52,7 +52,7 @@ var ContactEdit = {
ContactEdit.toggleCheckbox(checkbox); ContactEdit.toggleCheckbox(checkbox);
ContactEdit.updateNumber(li.closest(".dropdown_list"), li.parent().data("person_id"), aspectMembership.aspect_ids.length); ContactEdit.updateNumber(li.closest(".dropdown_list"), li.parent().data("person_id"), aspectMembership.aspect_ids.length);
Diaspora.widgets.publish("aspectDropdown/updated", [li.parent().data("person_id"), li.parents(".dropdown").get(0).outerHTML]); Diaspora.widgets.publish("aspectDropdown/updated", [li.parent().data("person_id"), li.parents(".dropdown").parent(".right").html()]);
}); });
}, },
}; };