From 884de9008f804218e6adc3423f7f6f2acba3b5e6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jonne=20Ha=C3=9F?= <me@jhass.eu>
Date: Sun, 2 Feb 2020 19:08:58 +0100
Subject: [PATCH] API: rename poll_answer_id to poll_answer in post
 interactions vote endpoint

---
 .../api/v1/post_interactions_controller.rb    |  2 +-
 .../api/post_interactions_controller_spec.rb  | 32 +++++++++----------
 2 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/app/controllers/api/v1/post_interactions_controller.rb b/app/controllers/api/v1/post_interactions_controller.rb
index 173bd3292..7b3f5237f 100644
--- a/app/controllers/api/v1/post_interactions_controller.rb
+++ b/app/controllers/api/v1/post_interactions_controller.rb
@@ -58,7 +58,7 @@ module Api
       def vote
         post = find_post
         begin
-          poll_vote = poll_service.vote(post.id, params[:poll_answer_id])
+          poll_vote = poll_service.vote(post.id, params[:poll_answer])
         rescue ActiveRecord::RecordNotFound
           # This, but not the find_post above, should return a 422,
           # we just keep poll_vote nil so it goes into the else below
diff --git a/spec/integration/api/post_interactions_controller_spec.rb b/spec/integration/api/post_interactions_controller_spec.rb
index b28a73dd0..d388e8a82 100644
--- a/spec/integration/api/post_interactions_controller_spec.rb
+++ b/spec/integration/api/post_interactions_controller_spec.rb
@@ -365,8 +365,8 @@ describe Api::V1::PostInteractionsController do
       post(
         api_v1_post_vote_path(@poll_post.guid),
         params: {
-          poll_answer_id: @poll_answer.id,
-          access_token:   access_token
+          poll_answer:  @poll_answer.id,
+          access_token: access_token
         }
       )
       expect(response.status).to eq(204)
@@ -377,16 +377,16 @@ describe Api::V1::PostInteractionsController do
       post(
         api_v1_post_vote_path(@poll_post.guid),
         params: {
-          poll_answer_id: @poll_answer.id,
-          access_token:   access_token
+          poll_answer:  @poll_answer.id,
+          access_token: access_token
         }
       )
       expect(response.status).to eq(204)
       post(
         api_v1_post_vote_path(@poll_post.guid),
         params: {
-          poll_answer_id: @poll_answer.id,
-          access_token:   access_token
+          poll_answer:  @poll_answer.id,
+          access_token: access_token
         }
       )
       confirm_api_error(response, 422, "Cant vote on this post")
@@ -396,8 +396,8 @@ describe Api::V1::PostInteractionsController do
       post(
         api_v1_post_vote_path(@poll_post.guid),
         params: {
-          poll_answer_id: -1,
-          access_token:   access_token
+          poll_answer:  -1,
+          access_token: access_token
         }
       )
       confirm_api_error(response, 422, "Cant vote on this post")
@@ -407,8 +407,8 @@ describe Api::V1::PostInteractionsController do
       post(
         api_v1_post_vote_path("999_999_999"),
         params: {
-          poll_answer_id: @poll_answer.id,
-          access_token:   access_token
+          poll_answer:  @poll_answer.id,
+          access_token: access_token
         }
       )
       confirm_api_error(response, 404, "Post with provided guid could not be found")
@@ -418,8 +418,8 @@ describe Api::V1::PostInteractionsController do
       post(
         api_v1_post_vote_path(@poll_post.guid),
         params: {
-          poll_answer_id: @poll_answer.id,
-          access_token:   access_token_minimum_scopes
+          poll_answer:  @poll_answer.id,
+          access_token: access_token_minimum_scopes
         }
       )
       expect(response.status).to eq(403)
@@ -429,8 +429,8 @@ describe Api::V1::PostInteractionsController do
       post(
         api_v1_post_vote_path(@shared_post.guid),
         params: {
-          poll_answer_id: @poll_answer.id,
-          access_token:   access_token_public_only
+          poll_answer:  @poll_answer.id,
+          access_token: access_token_public_only
         }
       )
       expect(response.status).to eq(404)
@@ -440,8 +440,8 @@ describe Api::V1::PostInteractionsController do
       post(
         api_v1_post_vote_path(@poll_post.guid),
         params: {
-          poll_answer_id: @poll_answer.id,
-          access_token:   invalid_token
+          poll_answer:  @poll_answer.id,
+          access_token: invalid_token
         }
       )
       expect(response.status).to eq(401)