From 8983554f949a1664eeeff5493bf10e09ce5b14ba Mon Sep 17 00:00:00 2001 From: Steffen van Bergerem Date: Sun, 13 Nov 2016 16:06:07 +0100 Subject: [PATCH] Improve profile header jasmine test * append html to spec.content() instead of body * don't append the unused conversations modal fixture * actually test that showModal has been called --- spec/javascripts/app/views/profile_header_view_spec.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/javascripts/app/views/profile_header_view_spec.js b/spec/javascripts/app/views/profile_header_view_spec.js index f6e78d934..17bfecc81 100644 --- a/spec/javascripts/app/views/profile_header_view_spec.js +++ b/spec/javascripts/app/views/profile_header_view_spec.js @@ -33,16 +33,16 @@ describe("app.views.ProfileHeader", function() { describe("showMessageModal", function() { beforeEach(function() { - $("body").append("
").append(spec.readFixture("conversations_modal")); + spec.content().append("
"); }); it("calls app.helpers.showModal", function() { spyOn(app.helpers, "showModal"); this.view.showMessageModal(); - expect(app.helpers.showModal); + expect(app.helpers.showModal).toHaveBeenCalled(); }); - it("app.views.ConversationsForm with correct parameterswhen modal is loaded", function() { + it("initializes app.views.ConversationsForm with correct parameters when modal is loaded", function() { gon.conversationPrefill = [ {id: 1, name: "diaspora user", handle: "diaspora-user@pod.tld"}, {id: 2, name: "other diaspora user", handle: "other-diaspora-user@pod.tld"},