DG MS; 404 show pages for objects that don't exist for given user

app/controllers/albums_controller.rb

@@ -37,8 +37,12 @@ class AlbumsController < ApplicationController
   def show
     @photo = Photo.new
     @album = current_user.find_visible_post_by_id( params[:id] )
-    @album_photos = @album.photos
+    unless @album
-    respond_with @album
+      render :file => "#{Rails.root}/public/404.html", :layout => false, :status => 404
+    else
+      @album_photos = @album.photos
+      respond_with @album
+    end
   end
 
   def edit

app/controllers/aspects_controller.rb

@@ -41,10 +41,14 @@ class AspectsController < ApplicationController
   end
 
   def show
-    @aspect  = current_user.aspect_by_id params[:id]
+    @aspect = current_user.aspect_by_id params[:id]
-    @friends = @aspect.people
+    unless @aspect
-    @posts   = current_user.visible_posts( :by_members_of => @aspect ).paginate :per_page => 15, :order => 'created_at DESC'
+      render :file => "#{Rails.root}/public/404.html", :layout => false, :status => 404
-    respond_with @aspect
+    else
+      @friends = @aspect.people
+      @posts   = current_user.visible_posts( :by_members_of => @aspect ).paginate :per_page => 15, :order => 'created_at DESC'
+      respond_with @aspect
+    end
   end
 
   def public

app/controllers/people_controller.rb

@@ -17,26 +17,18 @@ class PeopleController < ApplicationController
   end
 
   def show
-    begin
+    @person = current_user.visible_person_by_id(params[:id])
-      @person = current_user.visible_person_by_id(params[:id])
-    rescue BSON::InvalidObjectId
-      flash[:error] = "Person not found."
-      redirect_to people_path
-      return
-    end
     unless @person
-      flash[:error] = "Person not found."
+      render :file => "#{Rails.root}/public/404.html", :layout => false, :status => 404
-      redirect_to people_path
+    else
-      return
+      @profile = @person.profile
+      @aspects_with_person = current_user.aspects_with_person(@person)
+      @aspects_dropdown_array = current_user.aspects.collect{|x| [x.to_s, x.id]}
+      @posts = current_user.visible_posts(:person_id => @person.id).paginate :page => params[:page], :order => 'created_at DESC'
+      @latest_status_message = current_user.raw_visible_posts.find_all_by__type_and_person_id("StatusMessage", params[:id]).last
+      @post_count = @posts.count
+      respond_with @person
     end
-
-    @profile = @person.profile
-    @aspects_with_person = current_user.aspects_with_person(@person)
-    @aspects_dropdown_array = current_user.aspects.collect{|x| [x.to_s, x.id]}
-    @posts = current_user.visible_posts(:person_id => @person.id).paginate :page => params[:page], :order => 'created_at DESC'
-    @latest_status_message = current_user.raw_visible_posts.find_all_by__type_and_person_id("StatusMessage", params[:id]).last
-    @post_count = @posts.count
-    respond_with @person
   end
 
   def destroy

app/controllers/photos_controller.rb

@@ -76,8 +76,12 @@ class PhotosController < ApplicationController
 
   def show
     @photo = current_user.find_visible_post_by_id params[:id]
-    @album = @photo.album
+    unless @photo
-    respond_with @photo, @album
+      render :file => "#{Rails.root}/public/404.html", :layout => false, :status => 404
+    else
+      @album = @photo.album
+      respond_with @photo, @album
+    end
   end
 
   def edit

app/controllers/status_messages_controller.rb

@@ -33,7 +33,11 @@ class StatusMessagesController < ApplicationController
 
   def show
     @status_message = current_user.find_visible_post_by_id params[:id]
-    respond_with @status_message
+    unless @status_message
+      render :status => 404
+    else
+      respond_with @status_message
+    end
   end
 
   private

lib/diaspora/user/querying.rb

@@ -7,7 +7,7 @@ module Diaspora
     module Querying
 
       def find_visible_post_by_id( id )
-        self.raw_visible_posts.find id
+        self.raw_visible_posts.find id.to_id
       end
 
       def visible_posts( opts = {} )

lib/mongo_mapper/bson_id.rb

@@ -4,7 +4,11 @@
 
 class String
   def to_id
-    BSON::ObjectId self
+    begin
+      BSON::ObjectId self
+    rescue
+      nil
+    end
   end
 end
 class BSON::ObjectId