From 13698bece5a19ba078cbcba59bbe743064b3ef8a Mon Sep 17 00:00:00 2001 From: Benjamin Neff Date: Sun, 5 Mar 2017 01:56:50 +0100 Subject: [PATCH 01/40] Start 0.6.5.0 cycle --- Changelog.md | 8 ++++++++ config/defaults.yml | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/Changelog.md b/Changelog.md index b360d79b8..6fc8fd91a 100644 --- a/Changelog.md +++ b/Changelog.md @@ -1,3 +1,11 @@ +# 0.6.5.0 + +## Refactor + +## Bug fixes + +## Features + # 0.6.4.0 ## Refactor diff --git a/config/defaults.yml b/config/defaults.yml index ca3e4d5e6..7857a894b 100644 --- a/config/defaults.yml +++ b/config/defaults.yml @@ -4,7 +4,7 @@ defaults: version: - number: "0.6.3.99" # Do not touch unless doing a release, do not backport the version number that's in master + number: "0.6.4.99" # Do not touch unless doing a release, do not backport the version number that's in master heroku: false environment: url: "http://localhost:3000/" From e82005c517626f1cd8eafeceef560572c30eff02 Mon Sep 17 00:00:00 2001 From: Steffen van Bergerem Date: Sun, 5 Mar 2017 16:15:39 +0100 Subject: [PATCH 02/40] Disable Rails/HttpPositionalArguments cop See http://rubocop.readthedocs.io/en/latest/cops_rails/#railshttppositionalarguments. It only applies to Rails >= 5 closes #7353 --- .rubocop.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.rubocop.yml b/.rubocop.yml index fae72b1a6..2ebb26cff 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -6,6 +6,10 @@ AllCops: Rails: Enabled: true +# Disable for rails 4 +Rails/HttpPositionalArguments: + Enabled: false + # Commonly used screens these days easily fit more than 80 characters. Metrics/LineLength: Max: 120 From 0e28cfadb2ed63de6b571739bce2c850d78f3833 Mon Sep 17 00:00:00 2001 From: Senya Date: Mon, 6 Mar 2017 19:12:31 +0200 Subject: [PATCH 03/40] remove unused setPreload function closes #7354 --- Changelog.md | 1 + app/assets/javascripts/app/app.js | 5 ----- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/Changelog.md b/Changelog.md index 6fc8fd91a..7bea354f9 100644 --- a/Changelog.md +++ b/Changelog.md @@ -1,6 +1,7 @@ # 0.6.5.0 ## Refactor +* Remove unused setPreload function [#7354](https://github.com/diaspora/diaspora/pull/7354) ## Bug fixes diff --git a/app/assets/javascripts/app/app.js b/app/assets/javascripts/app/app.js index d95852882..57066f68d 100644 --- a/app/assets/javascripts/app/app.js +++ b/app/assets/javascripts/app/app.js @@ -60,11 +60,6 @@ var app = { return !!(window.gon.preloads && window.gon.preloads[prop]); //returning boolean variable so that parsePreloads, which cleans up properly is used instead }, - setPreload : function(prop, val) { - window.gon.preloads = window.gon.preloads || {}; - window.gon.preloads[prop] = val; - }, - parsePreload : function(prop) { if(!app.hasPreload(prop)) { return; } From a479db1c964ea3442fa6017f37c746903f5c9e1d Mon Sep 17 00:00:00 2001 From: cmrd Senya Date: Fri, 9 Dec 2016 21:08:38 +0200 Subject: [PATCH 04/40] a missing spy --- spec/javascripts/app/app_spec.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/spec/javascripts/app/app_spec.js b/spec/javascripts/app/app_spec.js index a1c987596..8a045ed78 100644 --- a/spec/javascripts/app/app_spec.js +++ b/spec/javascripts/app/app_spec.js @@ -4,6 +4,7 @@ describe("app", function() { spyOn(app.Router.prototype, "initialize"); spyOn(app, "setupDummyPreloads"); spyOn(app, "setupUser"); + spyOn(app, "setupAspects"); spyOn(app, "setupHeader"); spyOn(app, "setupBackboneLinks"); spyOn(app, "setupGlobalViews"); @@ -16,6 +17,7 @@ describe("app", function() { expect(app.Router.prototype.initialize).toHaveBeenCalled(); expect(app.setupDummyPreloads).toHaveBeenCalled(); expect(app.setupUser).toHaveBeenCalled(); + expect(app.setupAspects).toHaveBeenCalled(); expect(app.setupHeader).toHaveBeenCalled(); expect(app.setupBackboneLinks).toHaveBeenCalled(); expect(app.setupGlobalViews).toHaveBeenCalled(); From f36a4cd1f551b19e07bd1cae324a663dd3d62c9e Mon Sep 17 00:00:00 2001 From: cmrd Senya Date: Sat, 10 Dec 2016 00:19:47 +0200 Subject: [PATCH 05/40] don't use the deprecated ".selector" method --- spec/javascripts/app/app_spec.js | 9 ++++-- .../javascripts/app/views/search_view_spec.js | 2 +- spec/javascripts/app/views_spec.js | 29 ++++++++++++------- .../mobile/mobile_application_spec.js | 2 +- 4 files changed, 27 insertions(+), 15 deletions(-) diff --git a/spec/javascripts/app/app_spec.js b/spec/javascripts/app/app_spec.js index 8a045ed78..1ade3b556 100644 --- a/spec/javascripts/app/app_spec.js +++ b/spec/javascripts/app/app_spec.js @@ -41,18 +41,23 @@ describe("app", function() { }); describe("setupForms", function() { + beforeEach(function() { + spec.content().append("