From 8dc011cfb1f741d91fcc691601e8377e009b4d39 Mon Sep 17 00:00:00 2001 From: Steffen van Bergerem Date: Thu, 18 Aug 2016 20:30:17 +0200 Subject: [PATCH] Remove specs about services swallowing exceptions --- spec/models/services/facebook_spec.rb | 8 -------- spec/models/services/twitter_spec.rb | 6 ------ 2 files changed, 14 deletions(-) diff --git a/spec/models/services/facebook_spec.rb b/spec/models/services/facebook_spec.rb index d82ffeec2..162e72ef0 100644 --- a/spec/models/services/facebook_spec.rb +++ b/spec/models/services/facebook_spec.rb @@ -16,14 +16,6 @@ describe Services::Facebook, :type => :model do @service.post(@post) end - it 'swallows exception raised by facebook always being down' do - skip "temporarily disabled to figure out while some requests are failing" - - stub_request(:post,"https://graph.facebook.com/me/feed"). - to_raise(StandardError) - @service.post(@post) - end - it 'removes text formatting markdown from post text' do message = double(urls: []) expect(message).to receive(:plain_text_without_markdown).and_return("") diff --git a/spec/models/services/twitter_spec.rb b/spec/models/services/twitter_spec.rb index 720c1ccee..b2d09cae3 100644 --- a/spec/models/services/twitter_spec.rb +++ b/spec/models/services/twitter_spec.rb @@ -25,12 +25,6 @@ describe Services::Twitter, :type => :model do expect(@post.tweet_id).to match "1234" end - it 'swallows exception raised by twitter always being down' do - skip - expect_any_instance_of(Twitter::REST::Client).to receive(:update).and_raise(StandardError) - @service.post(@post) - end - it 'should call build_twitter_post' do url = "foo" expect(@service).to receive(:build_twitter_post).with(@post, 0)