nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

update tests for new twitter client

Browse source 
closes #6083
This commit is contained in:
Benjamin Neff 2015-06-08 03:25:24 +02:00 committed by Dennis Schubert
parent ec4e7b4a69
commit 97153ad08b
2 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Changelog.md
View file

@ -27,6 +27,7 @@
* Make used post title lengths more consistent [#6022](https://github.com/diaspora/diaspora/pull/6022) * Make used post title lengths more consistent [#6022](https://github.com/diaspora/diaspora/pull/6022)
* Improved logging source [#6041](https://github.com/diaspora/diaspora/pull/6041) * Improved logging source [#6041](https://github.com/diaspora/diaspora/pull/6041)
* Gracefully handle duplicate entry while receiving share-visibility in parallel [#6068](https://github.com/diaspora/diaspora/pull/6068) * Gracefully handle duplicate entry while receiving share-visibility in parallel [#6068](https://github.com/diaspora/diaspora/pull/6068)
* Update twitter gem to get rid of deprecation warnings [#6083](https://github.com/diaspora/diaspora/pull/6083)
## Bug fixes ## Bug fixes
* Disable auto follow back on aspect deletion [#5846](https://github.com/diaspora/diaspora/pull/5846) * Disable auto follow back on aspect deletion [#5846](https://github.com/diaspora/diaspora/pull/5846)

8
spec/models/services/twitter_spec.rb
View file

@ -12,11 +12,11 @@ describe Services::Twitter, :type => :model do
describe '#post' do describe '#post' do
before do before do
allow_any_instance_of(Twitter::Client).to receive(:update) { Twitter::Tweet.new(id: "1234") } allow_any_instance_of(Twitter::REST::Client).to receive(:update) { Twitter::Tweet.new(id: "1234") }
end end
it 'posts a status message to twitter' do it 'posts a status message to twitter' do
expect_any_instance_of(Twitter::Client).to receive(:update).with(instance_of(String)) expect_any_instance_of(Twitter::REST::Client).to receive(:update).with(instance_of(String))
@service.post(@post) @service.post(@post)
end end
@ -27,7 +27,7 @@ describe Services::Twitter, :type => :model do
it 'swallows exception raised by twitter always being down' do it 'swallows exception raised by twitter always being down' do
skip skip
expect_any_instance_of(Twitter::Client).to receive(:update).and_raise(StandardError) expect_any_instance_of(Twitter::REST::Client).to receive(:update).and_raise(StandardError)
@service.post(@post) @service.post(@post)
end end
@ -141,7 +141,7 @@ describe Services::Twitter, :type => :model do
it 'returns the original profile photo url' do it 'returns the original profile photo url' do
user_double = double user_double = double
expect(user_double).to receive(:profile_image_url_https).with("original").and_return("http://a2.twimg.com/profile_images/uid/avatar.png") expect(user_double).to receive(:profile_image_url_https).with("original").and_return("http://a2.twimg.com/profile_images/uid/avatar.png")
expect_any_instance_of(Twitter::Client).to receive(:user).with("joindiaspora").and_return(user_double) expect_any_instance_of(Twitter::REST::Client).to receive(:user).with("joindiaspora").and_return(user_double)
@service.nickname = "joindiaspora" @service.nickname = "joindiaspora"
expect(@service.profile_photo_url).to eq("http://a2.twimg.com/profile_images/uid/avatar.png") expect(@service.profile_photo_url).to eq("http://a2.twimg.com/profile_images/uid/avatar.png")