From 9970ee0e22e29eb31916514732e59391662201b4 Mon Sep 17 00:00:00 2001
From: Raphael <raphael@joindiaspora.com>
Date: Fri, 5 Nov 2010 14:15:19 -0700
Subject: [PATCH] Write comments controller spec

---
 app/controllers/comments_controller.rb       |  8 ++-
 spec/controllers/comments_controller_spec.rb | 60 ++++++++++++++++++++
 2 files changed, 66 insertions(+), 2 deletions(-)
 create mode 100644 spec/controllers/comments_controller_spec.rb

diff --git a/app/controllers/comments_controller.rb b/app/controllers/comments_controller.rb
index 8d5ce80fc..808566d0c 100644
--- a/app/controllers/comments_controller.rb
+++ b/app/controllers/comments_controller.rb
@@ -12,8 +12,12 @@ class CommentsController < ApplicationController
     target = current_user.find_visible_post_by_id params[:comment][:post_id]
     text = params[:comment][:text]
 
-    @comment = current_user.comment text, :on => target
-    render :nothing => true
+    @comment = current_user.comment(text, :on => target) if target
+    if @comment
+      render :nothing => true, :status => 201
+    else
+      render :nothing => true, :status => 401
+    end
   end
 
 end
diff --git a/spec/controllers/comments_controller_spec.rb b/spec/controllers/comments_controller_spec.rb
new file mode 100644
index 000000000..a6d95a536
--- /dev/null
+++ b/spec/controllers/comments_controller_spec.rb
@@ -0,0 +1,60 @@
+#   Copyright (c) 2010, Diaspora Inc.  This file is
+#   licensed under the Affero General Public License version 3 or later.  See
+#   the COPYRIGHT file.
+
+require 'spec_helper'
+
+describe CommentsController do
+  render_views
+
+  let!(:user) { make_user }
+  let!(:aspect) { user.aspects.create(:name => "AWESOME!!") }
+
+  let!(:user2) { make_user }
+  let!(:aspect2) { user2.aspects.create(:name => "WIN!!") }
+
+  before do
+    sign_in :user, user
+  end
+
+  describe '#create' do
+    let(:comment_hash) {
+      {:comment =>{
+        :text =>"facebook, is that you?", 
+        :post_id     =>"#{@post.id}"}}
+    }
+
+    context "on a post from a friend" do
+      before do
+        friend_users(user, aspect, user2, aspect2)
+        @post = user2.post :status_message, :message => 'GIANTS', :to => aspect2.id
+      end
+      it 'comments' do
+        post :create, comment_hash
+        response.code.should == '201'
+      end
+      it "doesn't overwrite person_id" do
+        new_user = make_user
+        comment_hash[:comment][:person_id] = new_user.person.id.to_s
+        post :create, comment_hash
+        Comment.find_by_text(comment_hash[:comment][:text]).person_id.should == user.person.id
+      end
+      it "doesn't overwrite id" do
+        old_comment = user.comment("hello", :on => @post)
+        comment_hash[:comment][:id] = old_comment.id
+        post :create, comment_hash
+        old_comment.reload.text.should == 'hello'
+      end
+    end
+    context 'on a post from a stranger' do
+      before do
+        @post = user2.post :status_message, :message => 'GIANTS', :to => aspect2.id
+      end
+      it 'posts no comment' do
+        user.should_receive(:comment).exactly(0).times
+        post :create, comment_hash
+        response.code.should == '401'
+      end
+    end
+  end
+end