From 9c87fff295434d659aa7e2fdfbf84c6407ec8636 Mon Sep 17 00:00:00 2001 From: Sarah Mei Date: Wed, 12 Jan 2011 22:43:45 -0800 Subject: [PATCH] Log specs don't check for specific number of renders. --- spec/controllers/aspects_controller_spec.rb | 1 - spec/controllers/home_controller_spec.rb | 1 - spec/shared_behaviors/log_override.rb | 6 ++---- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/spec/controllers/aspects_controller_spec.rb b/spec/controllers/aspects_controller_spec.rb index 06db2b8e1..cdfc79907 100644 --- a/spec/controllers/aspects_controller_spec.rb +++ b/spec/controllers/aspects_controller_spec.rb @@ -29,7 +29,6 @@ describe AspectsController do describe "custom logging on success" do before do @action = :index - @expected_renders = 15 end it_should_behave_like "it overrides the logs on success" end diff --git a/spec/controllers/home_controller_spec.rb b/spec/controllers/home_controller_spec.rb index 0c18ef5fb..40528366b 100644 --- a/spec/controllers/home_controller_spec.rb +++ b/spec/controllers/home_controller_spec.rb @@ -31,7 +31,6 @@ describe HomeController do before do @action = :show @action_params = {"lasers" => "green"} - @expected_renders = 1 end it_should_behave_like "it overrides the logs on success" end diff --git a/spec/shared_behaviors/log_override.rb b/spec/shared_behaviors/log_override.rb index a51a3c28e..8a604ec08 100644 --- a/spec/shared_behaviors/log_override.rb +++ b/spec/shared_behaviors/log_override.rb @@ -15,12 +15,10 @@ shared_examples_for 'it overrides the logs on success' do Rails.stub(:logger).and_return(FakeLogger.new) end context 'rendering' do - before do + it 'logs renders' do get @action, @action_params @lines = Rails.logger.infos.select { |l| l.include?("event=render") } - end - it 'logs all renders' do - @lines.length.should == @expected_renders + @lines.length.should > 0 end end context 'completion' do