nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Only mark unread notifications as read otherwise, the UPDATE statement would update all the notifications...

Browse source 
closes #6711
This commit is contained in:
Dennis Schubert 2016-02-22 06:52:34 +01:00 committed by Steffen van Bergerem
parent 0392549702
commit 9f2e5b1868
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Changelog.md
View file

@ -5,9 +5,10 @@
## Bug fixes
* Fix empty name field when editing aspect names [#6706](https://github.com/diaspora/diaspora/pull/6706)
* Fix internal server error when trying to log out of an expired session [#6707](https://github.com/diaspora/diaspora/pull/6707)
* Only mark unread notifications as read [#6711](https://github.com/diaspora/diaspora/pull/6711)
## Features
* Added the footer to conversation pages
* Added the footer to conversation pages [#6710](https://github.com/diaspora/diaspora/pull/6710)
# 0.5.7.0

7
app/controllers/notifications_controller.rb
View file

@ -61,9 +61,9 @@ class NotificationsController < ApplicationController
def read_all
current_type = Notification.types[params[:type]]
notifications = Notification.where(:recipient_id => current_user.id)
notifications = notifications.where(:type => current_type) if params[:type]
notifications.update_all(:unread => false)
notifications = Notification.where(recipient_id: current_user.id, unread: true)
notifications = notifications.where(type: current_type) if params[:type]
notifications.update_all(unread: false)
respond_to do |format|
if current_user.unread_notifications.count > 0
format.html { redirect_to notifications_path }
@ -75,7 +75,6 @@ class NotificationsController < ApplicationController
format.xml { render :xml => {}.to_xml }
format.json { render :json => {}.to_json }
end
end
end