nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Adjusting the description of the 404 message, in order to avoid having

Browse source 
to specify why users got a 404, and possibly leaking information while doing this

See discussion in #3717 for rationale on not implementing specific HTTP codes
This solves around #3717 and #3728

Adjusting travis breakage
This commit is contained in:
Nils Vogels 2013-08-30 11:51:55 +02:00 committed by Jonne Haß
parent 08dcc8c52d
commit a3f3bcf6ef
3 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/views/errors/not_public.haml
View file

@ -9,6 +9,6 @@
404 404
#content #content
= t('error_messages.post_not_public') = t('error_messages.post_not_public_or_not_exist')
%br %br
= t('error_messages.login_try_again', :login_link => new_user_session_path).html_safe = t('error_messages.login_try_again', :login_link => new_user_session_path).html_safe

1
config/locales/diaspora/en.yml
View file

@ -81,6 +81,7 @@ en:
invalid_fields: "Invalid Fields" invalid_fields: "Invalid Fields"
correct_the_following_errors_and_try_again: "Correct the following errors and try again." correct_the_following_errors_and_try_again: "Correct the following errors and try again."
post_not_public: "The post you are trying to view is not public!" post_not_public: "The post you are trying to view is not public!"
post_not_public_or_not_exist: "The post you are trying to view is not public, or does not exist!"
login_try_again: "Please <a href='%{login_link}'>login</a> and try again." login_try_again: "Please <a href='%{login_link}'>login</a> and try again."
admins: admins:

2
features/step_definitions/message_steps.rb
View file

@ -10,7 +10,7 @@ Then /^I should see the "(.*)" message$/ do |message|
when 'you are nsfw' when 'you are nsfw'
I18n.translate('profiles.edit.you_are_nsfw') I18n.translate('profiles.edit.you_are_nsfw')
when 'post not public' when 'post not public'
I18n.translate('error_messages.post_not_public') I18n.translate('error_messages.post_not_public_or_not_exist')
else else
raise "muriel, you don't have that message key, add one here" raise "muriel, you don't have that message key, add one here"
end end