Marked the problem area in infieldlabels

This commit is contained in:
Raphael 2010-06-30 21:53:05 -07:00
parent 63b3d0186a
commit a7659ae902

View file

@ -1,13 +1,13 @@
/* /**
* In-Field Label jQuery Plugin * @license In-Field Label jQuery Plugin
* http://fuelyourcoding.com/scripts/infield.html * http://fuelyourcoding.com/scripts/infield.html
* *
* Copyright (c) 2009 Doug Neiner * Copyright (c) 2009-2010 Doug Neiner
* Dual licensed under the MIT and GPL licenses. * Dual licensed under the MIT and GPL licenses.
* Uses the same license as jQuery, see: * Uses the same license as jQuery, see:
* http://docs.jquery.com/License * http://docs.jquery.com/License
* *
* @version 0.1 * @version 0.1.2
*/ */
(function ($) { (function ($) {
@ -31,10 +31,10 @@
base.options = $.extend({}, $.InFieldLabels.defaultOptions, options); base.options = $.extend({}, $.InFieldLabels.defaultOptions, options);
// Check if the field is already filled in // Check if the field is already filled in
if(base.$field.val() != ""){ if (base.$field.val() !== "") {
base.$label.hide(); base.$label.hide();
base.showing = false; base.showing = false;
}; }
base.$field.focus(function () { base.$field.focus(function () {
base.fadeOnFocus(); base.fadeOnFocus();
@ -44,6 +44,10 @@
// Use of a namespace (.infieldlabel) allows us to // Use of a namespace (.infieldlabel) allows us to
// unbind just this method later // unbind just this method later
base.hideOnChange(e); base.hideOnChange(e);
}).bind('paste', function (e) {
// Since you can not paste an empty string we can assume
// that the fieldis not empty and the label can be cleared.
base.setOpacity(0.0);
}).change(function (e) { }).change(function (e) {
base.checkForEmpty(); base.checkForEmpty();
}).bind('onPropertyChange', function () { }).bind('onPropertyChange', function () {
@ -57,7 +61,7 @@
base.fadeOnFocus = function () { base.fadeOnFocus = function () {
if (base.showing) { if (base.showing) {
base.setOpacity(base.options.fadeOpacity); base.setOpacity(base.options.fadeOpacity);
}; }
}; };
base.setOpacity = function (opacity) { base.setOpacity = function (opacity) {
@ -69,12 +73,12 @@
// set blur to true when passing from // set blur to true when passing from
// the blur event // the blur event
base.checkForEmpty = function (blur) { base.checkForEmpty = function (blur) {
if(base.$field.val() == ""){ if (base.$field.val() === "") {
base.prepForShow(); base.prepForShow();
base.setOpacity(blur ? 1.0 : base.options.fadeOpacity); base.setOpacity(blur ? 1.0 : base.options.fadeOpacity);
} else { } else {
base.setOpacity(0.0); base.setOpacity(0.0);
}; }
}; };
base.prepForShow = function (e) { base.prepForShow = function (e) {
@ -86,19 +90,21 @@
base.$field.bind('keydown.infieldlabel', function (e) { base.$field.bind('keydown.infieldlabel', function (e) {
base.hideOnChange(e); base.hideOnChange(e);
}); });
}; }
}; };
base.hideOnChange = function (e) { base.hideOnChange = function (e) {
if ( if (
(e.keyCode == 16) || // Skip Shift (e.keyCode === 16) || // Skip Shift
(e.keyCode == 9) // Skip Tab (e.keyCode === 9) // Skip Tab
) return; ) {
return;
}
if (base.showing) { if (base.showing) {
base.$label.hide(); base.$label.hide();
base.showing = false; base.showing = false;
}; }
// Remove keydown event to save on CPU processing // Remove keydown event to save on CPU processing
base.$field.unbind('keydown.infieldlabel'); base.$field.unbind('keydown.infieldlabel');
@ -119,22 +125,32 @@
// Find input or textarea based on for= attribute // Find input or textarea based on for= attribute
// The for attribute on the label must contain the ID // The for attribute on the label must contain the ID
// of the input or textarea element // of the input or textarea element
var for_attr = $(this).attr('for'); var for_attr = $(this).attr('for'), $field;
if( !for_attr ) return; // Nothing to attach, since the for field wasn't used if (!for_attr) {
return; // Nothing to attach, since the for field wasn't used
}
// Find the referenced input or textarea element // Find the referenced input or textarea element
var $field = $( // This fucking for_attr thing is some seriously dumb shit.
//
// It must be dealt with
$field = $(
"input#" + for_attr + "[type='text']," + "input#" + for_attr + "[type='text']," +
"input#" + for_attr + "[type='search']," +
"input#" + for_attr + "[type='tel']," +
"input#" + for_attr + "[type='url']," +
"input#" + for_attr + "[type='email']," +
"input#" + for_attr + "[type='password']," + "input#" + for_attr + "[type='password']," +
"textarea#" + for_attr "textarea#" + for_attr
); );
if( $field.length == 0) return; // Again, nothing to attach if ($field.length === 0) {
return; // Again, nothing to attach
}
// Only create object for input[text], input[password], or textarea // Only create object for input[text], input[password], or textarea
(new $.InFieldLabels(this, $field[0], options)); (new $.InFieldLabels(this, $field[0], options));
}); });
}; };
})(jQuery); }(jQuery));