From abd4e17daf2543a07b2a97e1c5868056b41cfcf4 Mon Sep 17 00:00:00 2001
From: Bobby Wilson <bobbywilson0@gmail.com>
Date: Thu, 22 Nov 2012 13:00:47 -0700
Subject: [PATCH] Fix #3750

---
 app/helpers/people_helper.rb           |  6 ++++--
 app/views/people/_sub_header.html.haml |  2 +-
 spec/helpers/people_helper_spec.rb     | 15 ++++++++++-----
 3 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/app/helpers/people_helper.rb b/app/helpers/people_helper.rb
index f40bc0821..ef751f1c5 100644
--- a/app/helpers/people_helper.rb
+++ b/app/helpers/people_helper.rb
@@ -39,8 +39,10 @@ module PeopleHelper
     "<a data-hovercard='#{remote_or_hovercard_link}' #{person_href(person)} class='#{opts[:class]}' #{ ("target=" + opts[:target]) if opts[:target]}>#{h(person.name)}</a>".html_safe
   end
 
-  def last_post_link(person)
-    link_to(t('people.last_post'), last_post_person_path(person.to_param)) unless person.posts.empty?
+  def last_visible_post_for(person, current_user=nil)
+    unless Post.visible_from_author(person, current_user).empty?
+      link_to(t('people.last_post'), last_post_person_path(person.to_param))
+    end
   end
 
   def person_image_tag(person, size = :thumb_small)
diff --git a/app/views/people/_sub_header.html.haml b/app/views/people/_sub_header.html.haml
index 1ad0a048d..f2dbb57b3 100644
--- a/app/views/people/_sub_header.html.haml
+++ b/app/views/people/_sub_header.html.haml
@@ -15,7 +15,7 @@
     = person.name
   %span.diaspora_handle
     = person.diaspora_handle
-    = last_post_link person
+    = last_visible_post_for person
 
   .description
     - if !person.tag_string.blank? && user_signed_in?
diff --git a/spec/helpers/people_helper_spec.rb b/spec/helpers/people_helper_spec.rb
index 98f461a8c..b8713e1da 100644
--- a/spec/helpers/people_helper_spec.rb
+++ b/spec/helpers/people_helper_spec.rb
@@ -60,18 +60,23 @@ describe PeopleHelper do
     end
   end
 
-  describe '#last_post_link' do
+  describe '#last_visible_post_for' do
     before do
       @person = FactoryGirl.create(:person)
     end
 
-    it "doesn't show a link, if the person has no posts" do
-      last_post_link(@person).should be_blank
+    it "doesn't show a link, if the person has no visible posts" do
+      last_visible_post_for(@person).should be_blank
     end
 
-    it "shows the link, if the person has at leas one post" do
+    it "doesn't show a link, if the person has posts but none visible" do
       post = FactoryGirl.create(:status_message, :author => @person)
-      last_post_link(@person).should include last_post_person_path(@person.to_param)
+      last_visible_post_for(@person).should be_blank
+    end
+
+    it "shows the link, if the person has at least one visible post" do
+      post = FactoryGirl.create(:status_message, :author => @person, :public => true)
+      last_visible_post_for(@person).should include last_post_person_path(@person.to_param)
     end
   end