nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove unused post interactions parse method

Browse source
This commit is contained in:
Steffen van Bergerem 2016-11-12 14:30:35 +01:00
parent 55349162bd
commit ad53a43f88
No known key found for this signature in database
GPG key ID: 315C9787D548DC6B
3 changed files with 3 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
app/assets/javascripts/app/models/post/interactions.js
View file

@ -14,33 +14,16 @@ app.models.Post.Interactions = Backbone.Model.extend({
this.reshares = new app.collections.Reshares(this.get("reshares"), {post : this.post});
},
parse : function(resp){
this.comments.reset(resp.comments);
this.likes.reset(resp.likes);
this.reshares.reset(resp.reshares);
var comments = this.comments
, likes = this.likes
, reshares = this.reshares;
return {
comments : comments,
likes : likes,
reshares : reshares,
fetched : true
};
},
likesCount : function(){
return this.get("fetched") ? this.likes.models.length : this.get("likes_count");
return this.get("likes_count");
},
resharesCount : function(){
return this.get("fetched") ? this.reshares.models.length : this.get("reshares_count");
return this.get("reshares_count");
},
commentsCount : function(){
return this.get("fetched") ? this.comments.models.length : this.get("comments_count");
return this.get("comments_count");
},
userLike : function(){

1
app/assets/javascripts/app/views/single-post-viewer/single_post_comment_stream.js
View file

@ -7,7 +7,6 @@ app.views.SinglePostCommentStream = app.views.CommentStream.extend({
this.CommentView = app.views.ExpandedComment;
$(window).on('hashchange',this.highlightPermalinkComment);
this.setupBindings();
this.model.comments.on("reset", this.render, this);
this.model.comments.fetch({success: function() {
setTimeout(this.highlightPermalinkComment, 0);
}.bind(this)});

8
spec/javascripts/app/views/single-post-view/single_post_comment_stream_spec.js
View file

@ -9,14 +9,6 @@ describe("app.views.SinglePostCommentStream", function() {
expect(this.view.CommentView).toBe(app.views.ExpandedComment);
});
it("calls render when the comments collection has been resetted", function() {
spyOn(app.views.SinglePostCommentStream.prototype, "render");
this.view.initialize();
expect(app.views.SinglePostCommentStream.prototype.render).not.toHaveBeenCalled();
this.post.comments.reset();
expect(app.views.SinglePostCommentStream.prototype.render).toHaveBeenCalled();
});
it("calls setupBindings", function() {
spyOn(app.views.SinglePostCommentStream.prototype, "setupBindings");
this.view.initialize();