nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use current-password and new-password for password autocomplete

Browse source 
closes #7642
fixes #7633
This commit is contained in:
flaburgan 2017-10-17 20:46:02 +02:00 committed by Benjamin Neff
parent 5a6bd47000
commit b156c2f1a3
No known key found for this signature in database
GPG key ID: 971464C3F1A90194
3 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Changelog.md
View file

@ -3,6 +3,7 @@
## Refactor
* Work on the data downloads: Fixed general layout of buttons, added a timestamp and implemented auto-deletion of old exports [#7684](https://github.com/diaspora/diaspora/pull/7684)
* Increase Twitter character limit to 280 [#7694](https://github.com/diaspora/diaspora/pull/7694)
* Improve password autocomplete with password managers [#7642](https://github.com/diaspora/diaspora/pull/7642)
## Bug fixes
* Fix invite link on the contacts page when the user has now contacts [#7690](https://github.com/diaspora/diaspora/pull/7690)

3
app/views/users/_close_account_modal.haml
View file

@ -34,7 +34,8 @@
= f.error_messages
.form-group
= f.label :close_account_password, t("users.edit.current_password"), for: :close_account_password
= f.password_field :current_password, id: :close_account_password, class: "form-control"
= f.password_field :current_password, id: :close_account_password, class: "form-control",
autocomplete: "current-password"
.modal-footer
.btn.btn-default{type: "button", data: {dismiss: "modal"}, aria: {hidden: "true"}}
= t("cancel")

6
app/views/users/_edit.haml
View file

@ -39,18 +39,18 @@
= f.label :current_password, t(".current_password"), class: "col-sm-6 control-label"
.col-sm-6
= f.password_field :current_password, placeholder: t(".current_password_expl"),
class: "form-control"
class: "form-control", autocomplete: "current-password"
.form-group
= f.label :password, t(".new_password"), class: "col-sm-6 control-label"
.col-sm-6
= f.password_field :password, placeholder: t(".character_minimum_expl"),
class: "form-control"
class: "form-control", autocomplete: "new-password"
.form-group
= f.label :password_confirmation, t("registrations.new.password_confirmation"),
class: "col-sm-6 control-label"
.col-sm-6
= f.password_field :password_confirmation, placeholder: t(".character_minimum_expl"),
class: "form-control"
class: "form-control", autocomplete: "new-password"
.clearfix
= f.submit t(".change_password"), class: "btn btn-primary pull-right", name: "change_password"