From b375bfa630d8ef148f6d3c8d9d1f7abd65b0af97 Mon Sep 17 00:00:00 2001
From: Akshay S Dinesh <akshay@learnlearn.in>
Date: Fri, 25 Jun 2021 22:41:56 +0530
Subject: [PATCH] Add more closing tags to fix specs

closes #8159
---
 app/assets/javascripts/app/views/hovercard_view.js |  2 +-
 app/assets/javascripts/app/views/locator.js        |  2 +-
 app/assets/javascripts/app/views/publisher_view.js |  2 +-
 app/assets/javascripts/mobile/mobile_comments.js   | 10 ++++++----
 app/assets/javascripts/mobile/publisher.js         |  2 +-
 spec/javascripts/app/app_spec.js                   |  2 +-
 spec/javascripts/app/views_spec.js                 |  8 ++++----
 spec/javascripts/mobile/mobile_comments_spec.js    |  4 ++--
 8 files changed, 17 insertions(+), 15 deletions(-)

diff --git a/app/assets/javascripts/app/views/hovercard_view.js b/app/assets/javascripts/app/views/hovercard_view.js
index 72ebe121a..9fe895bfe 100644
--- a/app/assets/javascripts/app/views/hovercard_view.js
+++ b/app/assets/javascripts/app/views/hovercard_view.js
@@ -130,7 +130,7 @@ app.views.Hovercard = app.views.Base.extend({
       // set hashtags
       this.hashtags.empty();
       this.hashtags.html($(_.map(person.profile.tags, function(tag) {
-        return $("<a/>", {href: Routes.tag(tag)}).text("#" + tag)[0];
+        return $("<a></a>", {href: Routes.tag(tag)}).text("#" + tag)[0];
       })));
     }
   },
diff --git a/app/assets/javascripts/app/views/locator.js b/app/assets/javascripts/app/views/locator.js
index 364f3fa39..56de93746 100644
--- a/app/assets/javascripts/app/views/locator.js
+++ b/app/assets/javascripts/app/views/locator.js
@@ -19,7 +19,7 @@ app.views.Location = Backbone.View.extend({
     var locator = new OSM.Locator();
     locator.getAddress(function(address, latlng){
       $(element).empty();
-      $("<input/>",
+      $("<input></input>",
         { id: "location_address",
           value: address,
           type: "text",
diff --git a/app/assets/javascripts/app/views/publisher_view.js b/app/assets/javascripts/app/views/publisher_view.js
index 84f957395..3dcd4ff50 100644
--- a/app/assets/javascripts/app/views/publisher_view.js
+++ b/app/assets/javascripts/app/views/publisher_view.js
@@ -351,7 +351,7 @@ app.views.Publisher = Backbone.View.extend({
     };
 
     var previewPost = new app.views.PreviewPost({model: new app.models.Post(previewMessage)}).render().el;
-    return $("<div/>").append(previewPost).html();
+    return $("<div></div>").append(previewPost).html();
   },
 
   keyDown : function(evt) {
diff --git a/app/assets/javascripts/mobile/mobile_comments.js b/app/assets/javascripts/mobile/mobile_comments.js
index 78dbe5e15..270799f7b 100644
--- a/app/assets/javascripts/mobile/mobile_comments.js
+++ b/app/assets/javascripts/mobile/mobile_comments.js
@@ -185,8 +185,8 @@
 
     addNewComments: function(bottomBar, data) {
       if ($(".comment-container", bottomBar).length === 0) {
-        $(".show-comments", bottomBar).after($("<div/>", {"class": "comment-container"}));
-        $(".comment-container", bottomBar).append($("<ul/>", {"class": "comments"}));
+        $(".show-comments", bottomBar).after($("<div></div>", {"class": "comment-container"}));
+        $(".comment-container", bottomBar).append($("<ul></ul>", {"class": "comments"}));
       }
       $(".comment-container .comments", bottomBar).append(data);
     },
@@ -212,8 +212,10 @@
         var postGuid = bottomBar.parents(".stream-element").data("guid");
 
         toggleReactionsLink.remove();
-        toggleReactionsLink = $("<a/>", {"class": "show-comments", "href": Routes.postComments(postGuid) + ".mobile"})
-          .html(text + "<i class='entypo-chevron-up'/>");
+        toggleReactionsLink = $("<a></a>", {
+          "class": "show-comments",
+          "href": Routes.postComments(postGuid) + ".mobile"
+        }).html(text + "<i class='entypo-chevron-up'/>");
         parent.prepend(toggleReactionsLink);
         bottomBar.removeClass("inactive").addClass("active");
       }
diff --git a/app/assets/javascripts/mobile/publisher.js b/app/assets/javascripts/mobile/publisher.js
index f50c6aa71..9bac0f0bf 100644
--- a/app/assets/javascripts/mobile/publisher.js
+++ b/app/assets/javascripts/mobile/publisher.js
@@ -33,7 +33,7 @@ $(document).ready(function(){
     if(hiddenField.length > 0) { hiddenField.remove(); }
     else {
       $("#new_status_message").append(
-        $("<input/>", {
+        $("<input></input>", {
           name: "services[]",
           type: "hidden",
           value: provider
diff --git a/spec/javascripts/app/app_spec.js b/spec/javascripts/app/app_spec.js
index 378ab84f3..1848f20a7 100644
--- a/spec/javascripts/app/app_spec.js
+++ b/spec/javascripts/app/app_spec.js
@@ -47,7 +47,7 @@ describe("app", function() {
 
   describe("setupForms", function() {
     beforeEach(function() {
-      spec.content().append("<textarea/> <input/>");
+      spec.content().append("<textarea></textarea> <input></input>");
     });
 
     it("calls jQuery.placeholder() for inputs", function() {
diff --git a/spec/javascripts/app/views_spec.js b/spec/javascripts/app/views_spec.js
index 370912436..5aa731840 100644
--- a/spec/javascripts/app/views_spec.js
+++ b/spec/javascripts/app/views_spec.js
@@ -62,8 +62,8 @@ describe("app.views.Base", function(){
             },
 
             postRenderTemplate : function(){
-              $(this.el).append("<div class=subview1/>");
-              $(this.el).append("<div class=subview2/>");
+              $(this.el).append("<div class=subview1></div>");
+              $(this.el).append("<div class=subview2></div>");
             },
 
             createSubview2 : function(){
@@ -121,7 +121,7 @@ describe("app.views.Base", function(){
       it("replaces .time with relative time ago in words", function() {
         this.view.templateName = false;
         spyOn($.fn, "timeago");
-        this.view.$el.append("<time/>");
+        this.view.$el.append("<time></time>");
         this.view.render();
         expect($.fn.timeago).toHaveBeenCalled();
         expect($.fn.timeago.calls.mostRecent().object.first().is("time")).toBe(true);
@@ -145,7 +145,7 @@ describe("app.views.Base", function(){
     beforeEach(function() {
       this.view.$el.htmlOriginal = this.view.$el.html;
       spyOn(this.view.$el, "html").and.callFake(function() {
-        this.htmlOriginal("<input><textarea/></input>");
+        this.htmlOriginal("<input><textarea></textarea></input>");
         return this;
       });
     });
diff --git a/spec/javascripts/mobile/mobile_comments_spec.js b/spec/javascripts/mobile/mobile_comments_spec.js
index af12f644c..81a754c4c 100644
--- a/spec/javascripts/mobile/mobile_comments_spec.js
+++ b/spec/javascripts/mobile/mobile_comments_spec.js
@@ -148,7 +148,7 @@ describe("Diaspora.Mobile.Comments", function(){
       var parent = this.toggleReactionsLink.parent();
       var postGuid = this.bottomBar.parents(".stream-element").data("guid");
       this.toggleReactionsLink.remove();
-      parent.prepend($("<span/>", {"class": "show-comments"}).text("0 comments"));
+      parent.prepend($("<span></span>", {"class": "show-comments"}).text("0 comments"));
 
       Diaspora.Mobile.Comments.increaseReactionCount(this.bottomBar);
       this.toggleReactionsLink = this.bottomBar.find(".show-comments").first();
@@ -160,7 +160,7 @@ describe("Diaspora.Mobile.Comments", function(){
       var parent = this.toggleReactionsLink.parent();
       var postGuid = this.bottomBar.parents(".stream-element").data("guid");
       this.toggleReactionsLink.remove();
-      parent.prepend($("<span/>", {"class": "show-comments"}).text("Aucun commentaire"));
+      parent.prepend($("<span></span>", {"class": "show-comments"}).text("Aucun commentaire"));
 
       Diaspora.Mobile.Comments.increaseReactionCount(this.bottomBar);
       this.toggleReactionsLink = this.bottomBar.find(".show-comments").first();