Merge pull request #5325 from gdpelican/feature/fix-change-password-error-message

Show error message on invalid reset password attempt

Changelog.md

@@ -67,6 +67,7 @@ The keys will still be available in the root level within the 0.5 release. The o
 * Only collapse empty comment box [#5328](https://github.com/diaspora/diaspora/pull/5328)
 * Fix pagination for people/guid/contacts [#5304](https://github.com/diaspora/diaspora/pull/5304)
 * Fix poll creation on Bootstrap pages [#5334](https://github.com/diaspora/diaspora/pull/5334)
+* Show error message on invalid reset password attempt [#5325](https://github.com/diaspora/diaspora/pull/5325)
 
 ## Features
 * Don't pull jQuery from a CDN by default [#5105](https://github.com/diaspora/diaspora/pull/5105)

app/views/passwords/new.haml

@@ -5,6 +5,8 @@
   %h1{id: "huge-text"}= AppConfig.settings.pod_name
 
   = form_for(resource, :as => resource_name, :url => password_path(resource_name), :html => {:class => "form-horizontal block-form"}, :autocomplete => 'off') do |f|
+    %legend
+      %i=  t('devise.passwords.new.no_account') unless devise_error_messages!.empty?
     %fieldset
       .control-group
         %label{class: "control-label", for: "user_email", style: "width: 40%; text-align: center; padding: 10px 0; overflow: hidden"}

features/desktop/change_password.feature

@@ -22,3 +22,9 @@ Feature: Change password
     When I fill out reset password form with "supersecret" and "supersecret"
     And I submit reset password form
     Then I should be on the stream page
+
+  Scenario: Attempt to reset password with invalid email
+    Given I am on forgot password page
+    When I fill out forgot password form with "notanemail"
+    And I submit forgot password form
+    Then I should see "No account with this email exists"