diff --git a/app/assets/javascripts/app/helpers/handlebars-helpers.js b/app/assets/javascripts/app/helpers/handlebars-helpers.js index 0a75ebbb6..a6ed3de0c 100644 --- a/app/assets/javascripts/app/helpers/handlebars-helpers.js +++ b/app/assets/javascripts/app/helpers/handlebars-helpers.js @@ -116,7 +116,7 @@ Handlebars.registerHelper("isCurrentProfilePage", function(id, diasporaHandle, o }); Handlebars.registerHelper('aspectMembershipIndicator', function(contact,in_aspect) { - if(!app.aspect || !app.aspect.get('id')) return '
'; + if(!app.aspect || !app.aspect.get('id')) return '
'; var html = " .pull-right > .aspect_membership_dropdown { display: none; } + & > .pull-right > .aspect-membership-dropdown { display: none; } } .ajax-loader { border-bottom: 1px solid $border-grey; diff --git a/app/assets/stylesheets/hovercard.scss b/app/assets/stylesheets/hovercard.scss index 50867da4b..c664ee467 100644 --- a/app/assets/stylesheets/hovercard.scss +++ b/app/assets/stylesheets/hovercard.scss @@ -65,7 +65,7 @@ margin-bottom: 5px; } - .btn-group.aspect_membership_dropdown { margin: 0 !important; } + .btn-group.aspect-membership-dropdown { margin: 0 !important; } } #hovercard_container { diff --git a/app/assets/stylesheets/notifications.scss b/app/assets/stylesheets/notifications.scss index d3ffa2f2b..d75e1bdf7 100644 --- a/app/assets/stylesheets/notifications.scss +++ b/app/assets/stylesheets/notifications.scss @@ -96,6 +96,6 @@ opacity: 0; } - .btn-group.aspect_membership_dropdown { margin: 5px 0; } + .btn-group.aspect-membership-dropdown { margin: 5px 0; } } } diff --git a/app/assets/stylesheets/people.scss b/app/assets/stylesheets/people.scss index 5e2e5a1a4..65a9100ae 100644 --- a/app/assets/stylesheets/people.scss +++ b/app/assets/stylesheets/people.scss @@ -20,7 +20,7 @@ width: 50px; height: 50px; } - .btn-group.aspect_membership_dropdown { margin: 12px 0; } + .btn-group.aspect-membership-dropdown { margin: 12px 0; } .thats_you { line-height: 50px; margin-right: 10px; diff --git a/app/assets/templates/profile_header_tpl.jst.hbs b/app/assets/templates/profile_header_tpl.jst.hbs index 4885810e5..e6f94881f 100644 --- a/app/assets/templates/profile_header_tpl.jst.hbs +++ b/app/assets/templates/profile_header_tpl.jst.hbs @@ -33,7 +33,7 @@ {{else}} {{#if is_blocked}} {{t 'people.stop_ignoring'}} {{else}} -
+
{{/if}}{{/if}} {{/if}} diff --git a/app/views/aspect_memberships/_aspect_membership_dropdown.haml b/app/views/aspect_memberships/_aspect_membership_dropdown.haml index 0274ba91d..a7e690c8b 100644 --- a/app/views/aspect_memberships/_aspect_membership_dropdown.haml +++ b/app/views/aspect_memberships/_aspect_membership_dropdown.haml @@ -1 +1 @@ -.placeholder.aspect_membership_dropdown +.placeholder.aspect-membership-dropdown diff --git a/app/views/notifications/_notification.haml b/app/views/notifications/_notification.haml index 23ff76fd3..cba9824c4 100644 --- a/app/views/notifications/_notification.haml +++ b/app/views/notifications/_notification.haml @@ -6,7 +6,7 @@ - if note.target.present? - gon_load_contact(note.contact) .pull-right - .aspect_membership_dropdown.placeholder{data: {person_id: note.target.id}} + .aspect-membership-dropdown.placeholder{data: {person_id: note.target.id}} .media-object.pull-left = person_image_link note.actors.first, :size => :thumb_small, :class => 'hovercardable' diff --git a/app/views/people/_relationship_action.haml b/app/views/people/_relationship_action.haml index 01593dec7..c05e8dedf 100644 --- a/app/views/people/_relationship_action.haml +++ b/app/views/people/_relationship_action.haml @@ -1,5 +1,5 @@ - unless person == current_user.person - .aspect_membership_dropdown.placeholder{data: {person_id: person.id}} + .aspect-membership-dropdown.placeholder{data: {person_id: person.id}} -else %span.thats_you = t("people.person.thats_you") diff --git a/features/desktop/connects_users.feature b/features/desktop/connects_users.feature index b9f934735..7016c8351 100644 --- a/features/desktop/connects_users.feature +++ b/features/desktop/connects_users.feature @@ -30,7 +30,7 @@ Feature: following and being followed When I sign in as "alice@alice.alice" And I am on "bob@bob.bob"'s page - And I press the first ".aspect_membership_dropdown .dropdown-toggle" + And I press the first ".aspect-membership-dropdown .dropdown-toggle" And I press the first "a" within ".add_aspect" And I fill in "aspect_name" with "Super People" in the aspect creation modal diff --git a/features/step_definitions/aspects_steps.rb b/features/step_definitions/aspects_steps.rb index 8d05a421e..d7c981479 100644 --- a/features/step_definitions/aspects_steps.rb +++ b/features/step_definitions/aspects_steps.rb @@ -15,13 +15,13 @@ module AspectCukeHelpers end def toggle_aspect_via_ui(aspect_name) - aspects_dropdown = find(".aspect_membership_dropdown .dropdown-toggle", match: :first) + aspects_dropdown = find(".aspect-membership-dropdown .dropdown-toggle", match: :first) aspects_dropdown.trigger "click" - selected_aspect_count = all(".aspect_membership_dropdown.open .dropdown-menu li.selected").length - aspect = find(".aspect_membership_dropdown.open .dropdown-menu li", text: aspect_name) + selected_aspect_count = all(".aspect-membership-dropdown.open .dropdown-menu li.selected").length + aspect = find(".aspect-membership-dropdown.open .dropdown-menu li", text: aspect_name) aspect_selected = aspect["class"].include? "selected" aspect.trigger "click" - expect(find(".aspect_membership_dropdown .dropdown-menu", visible: false)).to have_no_css(".loading") + expect(find(".aspect-membership-dropdown .dropdown-menu", visible: false)).to have_no_css(".loading") # close dropdown page.should have_no_css('#profile.loading') @@ -31,7 +31,7 @@ module AspectCukeHelpers end def aspect_dropdown_visible? - expect(find('.aspect_membership_dropdown.open')).to be_visible + expect(find('.aspect-membership-dropdown.open')).to be_visible end end World(AspectCukeHelpers) diff --git a/spec/controllers/notifications_controller_spec.rb b/spec/controllers/notifications_controller_spec.rb index 58a078bcb..505786eb7 100644 --- a/spec/controllers/notifications_controller_spec.rb +++ b/spec/controllers/notifications_controller_spec.rb @@ -119,7 +119,7 @@ describe NotificationsController, :type => :controller do eve.share_with(alice.person, eve.aspects.first) get :index, params: {per_page: 5} - expect(Nokogiri(response.body).css(".aspect_membership_dropdown")).not_to be_empty + expect(Nokogiri(response.body).css(".aspect-membership-dropdown")).not_to be_empty end it 'succeeds on mobile' do