nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Delete invalid oEmbed caches with binary titles

Browse source 
There are a few old oEmbed caches which have the title saved in binary
(because they contain Chinese characters). This fails with
`ActionView::Template::Error ("å" from ASCII-8BIT to UTF-8)`. Since I
found only very old OEmbed caches with this problem (newest from 2012),
I think we can just remove these. When I create a new oEmbed cache for
the same URL it creates it without `!binary`.

closes #7620
This commit is contained in:
Benjamin Neff 2017-09-17 18:54:57 +02:00
parent 3fafcd9307
commit b8fb4b6251
No known key found for this signature in database
GPG key ID: 971464C3F1A90194
2 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Changelog.md
View file

@ -24,6 +24,7 @@
* Fix invalid data in the database for user data export [#7614](https://github.com/diaspora/diaspora/pull/7614)
* Fix local migration run without old private key [#7558](https://github.com/diaspora/diaspora/pull/7558)
* Fix export not downloadable because the filename was resetted on access [#7622](https://github.com/diaspora/diaspora/pull/7622)
* Delete invalid oEmbed caches with binary titles [#7620](https://github.com/diaspora/diaspora/pull/7620)
## Features
* Ask for confirmation when leaving a submittable comment field [#7530](https://github.com/diaspora/diaspora/pull/7530)

12
db/migrate/20170917163640_cleanup_invalid_o_embed_caches.rb Normal file
View file

@ -0,0 +1,12 @@
class CleanupInvalidOEmbedCaches < ActiveRecord::Migration[5.1]
class OEmbedCache < ApplicationRecord
end
class Post < ApplicationRecord
end
def up
ids = OEmbedCache.where("data LIKE '%!binary%'").ids
Post.where(o_embed_cache_id: ids).update_all(o_embed_cache_id: nil) # rubocop:disable Rails/SkipsModelValidations
OEmbedCache.where(id: ids).delete_all
end
end