nocebo/diaspora
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add logging for GC (slight slowdown, but worth it for the data)

Browse source
This commit is contained in:
Raphael Sofaer 2011-02-10 15:51:22 -08:00
parent 0b6375ae63
commit bb58544a70
3 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/controllers/application_controller.rb
View file

@ -11,6 +11,7 @@ class ApplicationController < ActionController::Base
before_filter :set_invites before_filter :set_invites
before_filter :set_locale before_filter :set_locale
before_filter :which_action_and_user before_filter :which_action_and_user
prepend_before_filter :clear_gc_stats
def set_contacts_notifications_and_status def set_contacts_notifications_and_status
if user_signed_in? if user_signed_in?
@ -50,4 +51,7 @@ class ApplicationController < ActionController::Base
I18n.locale = request.compatible_language_from AVAILABLE_LANGUAGE_CODES I18n.locale = request.compatible_language_from AVAILABLE_LANGUAGE_CODES
end end
end end
def clear_gc_stats
GC.clear_stats if GC.respond_to?(:clear_stats)
end
end end

1
config/environments/production.rb
View file

@ -51,3 +51,4 @@ end
# Sacrifice readability for a 10% performance boost # Sacrifice readability for a 10% performance boost
Haml::Template::options[:ugly] = true Haml::Template::options[:ugly] = true
GC.enable_stats if GC.respond_to?(:enable_stats)

2
lib/log_overrider.rb
View file

@ -19,6 +19,7 @@ module ActionDispatch
ActiveSupport::Deprecation.silence do ActiveSupport::Deprecation.silence do
message = "event=error error_class=#{exception.class} error_message='#{exception.message}' " message = "event=error error_class=#{exception.class} error_message='#{exception.message}' "
message << "gc_ms=#{GC.time} gc_collections=#{GC.collections} gc_bytes=#{GC.growth} " if GC.respond_to?(:enable_stats)
message << "orig_error_message='#{exception.original_exception.message}'" if exception.respond_to?(:original_exception) message << "orig_error_message='#{exception.original_exception.message}'" if exception.respond_to?(:original_exception)
message << "annotated_source='#{exception.annoted_source_code.to_s}' " if exception.respond_to?(:annoted_source_code) message << "annotated_source='#{exception.annoted_source_code.to_s}' " if exception.respond_to?(:annoted_source_code)
message << "app_backtrace='#{application_trace(exception).join(";")}'" message << "app_backtrace='#{application_trace(exception).join(";")}'"
@ -41,6 +42,7 @@ class ActionController::LogSubscriber
log_string = "event=request_completed status=#{payload[:status]} " log_string = "event=request_completed status=#{payload[:status]} "
log_string << "controller=#{payload[:controller]} action=#{payload[:action]} format=#{payload[:formats].first.to_s.upcase} " log_string << "controller=#{payload[:controller]} action=#{payload[:action]} format=#{payload[:formats].first.to_s.upcase} "
log_string << "ms=#{"%.0f" % event.duration} " log_string << "ms=#{"%.0f" % event.duration} "
log_string << "gc_ms=#{GC.time} gc_collections=#{GC.collections} gc_bytes=#{GC.growth} " if GC.respond_to?(:enable_stats)
log_string << "params='#{params.inspect}' " unless params.empty? log_string << "params='#{params.inspect}' " unless params.empty?
#log_string << "additions='#{additions.join(" | ")}' " unless additions.blank? #log_string << "additions='#{additions.join(" | ")}' " unless additions.blank?